Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-16 Thread Kuankuan.Yang
在 2014年12月16日 17:34, Russell King - ARM Linux 写道: On Tue, Dec 16, 2014 at 02:17:51PM +0800, Kuankuan.Yang wrote: hdmi-audio driver share irq with dw_hdmi driver, for continuing AHBAUDDMA or for detecting hdmi insert. So maybe it's hard to switch to simple-card way, Russell what's your

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-16 Thread Russell King - ARM Linux
On Tue, Dec 16, 2014 at 02:17:51PM +0800, Kuankuan.Yang wrote: > hdmi-audio driver share irq with dw_hdmi driver, for continuing AHBAUDDMA > or for detecting hdmi insert. > So maybe it's hard to switch to simple-card way, Russell what's your > opinion ? My "opinion" is that I need to spend some

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-16 Thread Russell King - ARM Linux
On Tue, Dec 16, 2014 at 02:17:51PM +0800, Kuankuan.Yang wrote: hdmi-audio driver share irq with dw_hdmi driver, for continuing AHBAUDDMA or for detecting hdmi insert. So maybe it's hard to switch to simple-card way, Russell what's your opinion ? My opinion is that I need to spend some time

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-16 Thread Kuankuan.Yang
在 2014年12月16日 17:34, Russell King - ARM Linux 写道: On Tue, Dec 16, 2014 at 02:17:51PM +0800, Kuankuan.Yang wrote: hdmi-audio driver share irq with dw_hdmi driver, for continuing AHBAUDDMA or for detecting hdmi insert. So maybe it's hard to switch to simple-card way, Russell what's your

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
在 2014年12月16日 00:18, Mark Brown 写道: On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: Hi Mark & Russell: Please don't top post, that way people have some context for what you're saying - look at how people normally format their mails on thelist. In that way, dt will only need

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
在 2014年12月16日 00:18, Mark Brown 写道: On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: Hi Mark & Russell: Please don't top post, that way people have some context for what you're saying - look at how people normally format their mails on thelist. got it, thanks for your remind.

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
Hi Mark : Got it, it will be good to use simple-card. i will try it in next version. Best Regards. 在 2014年12月16日 00:18, Mark Brown 写道: On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: Hi Mark & Russell: Please don't top post, that way people have some context for what you're

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Mark Brown
On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: > Hi Mark & Russell: Please don't top post, that way people have some context for what you're saying - look at how people normally format their mails on thelist. > In that way, dt will only need compatible for creating sound device.

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
Hi Mark & Russell: thanks for your replay, what your say is right, those dt is merely describing the Linux kernel internals. Instead of transmit cpu-of-node & codec-name & codec-dai-name through dt, i can give those an const name to rockchip-hdmi-audio.c . In that way, dt will only need

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Mark Brown
On Mon, Dec 15, 2014 at 10:40:29AM +, Russell King - ARM Linux wrote: > Including details like this (because ASoC needs a separate DT node) is > the wrong approach. And indeed there should be no Linux-internal reason for that - we should be able to use whatever DT node makes sense, if

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Russell King - ARM Linux
On Mon, Dec 15, 2014 at 10:55:14AM +0800, Yakir Yang wrote: > Required properties: > - compatible: platform specific > - cpu-of-node: the device node of cpu_dai > - codec-name: the dw-hdmi codec's device name > - codec-dai-name: the dw-hdmi codec's dai name This is not actually a separate

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
Hi lars: thks for your review, I will move it to hdmi audio driver, give the codec_name & codec_dai_name an const string. Best Regards. 在 2014年12月15日 17:02, Lars-Peter Clausen 写道: On 12/15/2014 03:55 AM, Yakir Yang wrote: [...] +- codec-name: the dw-hdmi codec's device name +-

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Lars-Peter Clausen
On 12/15/2014 03:55 AM, Yakir Yang wrote: [...] +- codec-name: the dw-hdmi codec's device name +- codec-dai-name: the dw-hdmi codec's dai name Please you phandles for this, the names are Linux driver and framework specific details. That should not leak into the DT bindings. [..] -- To

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Lars-Peter Clausen
On 12/15/2014 03:55 AM, Yakir Yang wrote: [...] +- codec-name: the dw-hdmi codec's device name +- codec-dai-name: the dw-hdmi codec's dai name Please you phandles for this, the names are Linux driver and framework specific details. That should not leak into the DT bindings. [..] -- To

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
Hi lars: thks for your review, I will move it to hdmi audio driver, give the codec_name codec_dai_name an const string. Best Regards. 在 2014年12月15日 17:02, Lars-Peter Clausen 写道: On 12/15/2014 03:55 AM, Yakir Yang wrote: [...] +- codec-name: the dw-hdmi codec's device name +-

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Russell King - ARM Linux
On Mon, Dec 15, 2014 at 10:55:14AM +0800, Yakir Yang wrote: Required properties: - compatible: platform specific - cpu-of-node: the device node of cpu_dai - codec-name: the dw-hdmi codec's device name - codec-dai-name: the dw-hdmi codec's dai name This is not actually a separate physical

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Mark Brown
On Mon, Dec 15, 2014 at 10:40:29AM +, Russell King - ARM Linux wrote: Including details like this (because ASoC needs a separate DT node) is the wrong approach. And indeed there should be no Linux-internal reason for that - we should be able to use whatever DT node makes sense, if there's

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
Hi Mark Russell: thanks for your replay, what your say is right, those dt is merely describing the Linux kernel internals. Instead of transmit cpu-of-node codec-name codec-dai-name through dt, i can give those an const name to rockchip-hdmi-audio.c . In that way, dt will only need

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Mark Brown
On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: Hi Mark Russell: Please don't top post, that way people have some context for what you're saying - look at how people normally format their mails on thelist. In that way, dt will only need compatible for creating sound device. is

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
Hi Mark : Got it, it will be good to use simple-card. i will try it in next version. Best Regards. 在 2014年12月16日 00:18, Mark Brown 写道: On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: Hi Mark Russell: Please don't top post, that way people have some context for what you're

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
在 2014年12月16日 00:18, Mark Brown 写道: On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: Hi Mark Russell: Please don't top post, that way people have some context for what you're saying - look at how people normally format their mails on thelist. got it, thanks for your remind.

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Kuankuan.Yang
在 2014年12月16日 00:18, Mark Brown 写道: On Mon, Dec 15, 2014 at 09:10:26PM +0800, Kuankuan.Yang wrote: Hi Mark Russell: Please don't top post, that way people have some context for what you're saying - look at how people normally format their mails on thelist. In that way, dt will only need

[PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-14 Thread Yakir Yang
Required properties: - compatible: platform specific - cpu-of-node: the device node of cpu_dai - codec-name: the dw-hdmi codec's device name - codec-dai-name: the dw-hdmi codec's dai name Signed-off-by: Yakir Yang --- .../bindings/sound/rockchip,rockchip-hdmi-audio.txt | 16

[PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-14 Thread Yakir Yang
Required properties: - compatible: platform specific - cpu-of-node: the device node of cpu_dai - codec-name: the dw-hdmi codec's device name - codec-dai-name: the dw-hdmi codec's dai name Signed-off-by: Yakir Yang y...@rock-chips.com --- .../bindings/sound/rockchip,rockchip-hdmi-audio.txt