Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-22 Thread John Garry
I would like to make another point about why I am making this change in case it is not clear. The queue full events are form TRANS_TX_CREDIT_TIMEOUT_ERR and TRANS_TX_CLOSE_NORMAL_ERR errors in the slot: I want the slot retried when this occurs, so I set status as SAS_QUEUE_FULL just so we will

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-22 Thread John Garry
I would like to make another point about why I am making this change in case it is not clear. The queue full events are form TRANS_TX_CREDIT_TIMEOUT_ERR and TRANS_TX_CLOSE_NORMAL_ERR errors in the slot: I want the slot retried when this occurs, so I set status as SAS_QUEUE_FULL just so we will

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-19 Thread Hannes Reinecke
On 02/19/2016 11:46 AM, John Garry wrote: > On 18/02/2016 10:57, John Garry wrote: >> On 18/02/2016 10:30, Hannes Reinecke wrote: >>> On 02/18/2016 11:12 AM, John Garry wrote: On 18/02/2016 07:40, Hannes Reinecke wrote: >>> [ .. ] > Well, the classical thing would be to associate each

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-19 Thread Hannes Reinecke
On 02/19/2016 11:46 AM, John Garry wrote: > On 18/02/2016 10:57, John Garry wrote: >> On 18/02/2016 10:30, Hannes Reinecke wrote: >>> On 02/18/2016 11:12 AM, John Garry wrote: On 18/02/2016 07:40, Hannes Reinecke wrote: >>> [ .. ] > Well, the classical thing would be to associate each

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-19 Thread John Garry
On 18/02/2016 10:57, John Garry wrote: On 18/02/2016 10:30, Hannes Reinecke wrote: On 02/18/2016 11:12 AM, John Garry wrote: On 18/02/2016 07:40, Hannes Reinecke wrote: [ .. ] Well, the classical thing would be to associate each request tag with a SAS task; or, in your case, associate each

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-19 Thread John Garry
On 18/02/2016 10:57, John Garry wrote: On 18/02/2016 10:30, Hannes Reinecke wrote: On 02/18/2016 11:12 AM, John Garry wrote: On 18/02/2016 07:40, Hannes Reinecke wrote: [ .. ] Well, the classical thing would be to associate each request tag with a SAS task; or, in your case, associate each

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-18 Thread John Garry
On 18/02/2016 10:30, Hannes Reinecke wrote: On 02/18/2016 11:12 AM, John Garry wrote: On 18/02/2016 07:40, Hannes Reinecke wrote: [ .. ] Well, the classical thing would be to associate each request tag with a SAS task; or, in your case, associate each slot index with a request tag. You

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-18 Thread John Garry
On 18/02/2016 10:30, Hannes Reinecke wrote: On 02/18/2016 11:12 AM, John Garry wrote: On 18/02/2016 07:40, Hannes Reinecke wrote: [ .. ] Well, the classical thing would be to associate each request tag with a SAS task; or, in your case, associate each slot index with a request tag. You

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-18 Thread Hannes Reinecke
On 02/18/2016 11:12 AM, John Garry wrote: > On 18/02/2016 07:40, Hannes Reinecke wrote: [ .. ] >> Well, the classical thing would be to associate each request tag >> with a SAS task; or, in your case, associate each slot index with a >> request tag. >> You probably would need to reserve some slots

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-18 Thread Hannes Reinecke
On 02/18/2016 11:12 AM, John Garry wrote: > On 18/02/2016 07:40, Hannes Reinecke wrote: [ .. ] >> Well, the classical thing would be to associate each request tag >> with a SAS task; or, in your case, associate each slot index with a >> request tag. >> You probably would need to reserve some slots

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-18 Thread John Garry
On 18/02/2016 07:40, Hannes Reinecke wrote: On 02/16/2016 05:56 PM, John Garry wrote: On 16/02/2016 15:33, Hannes Reinecke wrote: On 02/16/2016 01:22 PM, John Garry wrote: In high-datarate aging tests, it is found that the SCSI framework can periodically issue lu resets to the device. This is

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-18 Thread John Garry
On 18/02/2016 07:40, Hannes Reinecke wrote: On 02/16/2016 05:56 PM, John Garry wrote: On 16/02/2016 15:33, Hannes Reinecke wrote: On 02/16/2016 01:22 PM, John Garry wrote: In high-datarate aging tests, it is found that the SCSI framework can periodically issue lu resets to the device. This is

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-17 Thread Hannes Reinecke
On 02/16/2016 05:56 PM, John Garry wrote: > On 16/02/2016 15:33, Hannes Reinecke wrote: >> On 02/16/2016 01:22 PM, John Garry wrote: >>> In high-datarate aging tests, it is found that >>> the SCSI framework can periodically >>> issue lu resets to the device. This is because scsi >>> commands begin

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-17 Thread Hannes Reinecke
On 02/16/2016 05:56 PM, John Garry wrote: > On 16/02/2016 15:33, Hannes Reinecke wrote: >> On 02/16/2016 01:22 PM, John Garry wrote: >>> In high-datarate aging tests, it is found that >>> the SCSI framework can periodically >>> issue lu resets to the device. This is because scsi >>> commands begin

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread John Garry
On 16/02/2016 15:33, Hannes Reinecke wrote: On 02/16/2016 01:22 PM, John Garry wrote: In high-datarate aging tests, it is found that the SCSI framework can periodically issue lu resets to the device. This is because scsi commands begin to timeout. It is found that TASK SET FULL may be returned

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread John Garry
On 16/02/2016 15:33, Hannes Reinecke wrote: On 02/16/2016 01:22 PM, John Garry wrote: In high-datarate aging tests, it is found that the SCSI framework can periodically issue lu resets to the device. This is because scsi commands begin to timeout. It is found that TASK SET FULL may be returned

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread Hannes Reinecke
On 02/16/2016 01:22 PM, John Garry wrote: > In high-datarate aging tests, it is found that > the SCSI framework can periodically > issue lu resets to the device. This is because scsi > commands begin to timeout. It is found that TASK SET > FULL may be returned many times for the same command, >

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread Hannes Reinecke
On 02/16/2016 01:22 PM, John Garry wrote: > In high-datarate aging tests, it is found that > the SCSI framework can periodically > issue lu resets to the device. This is because scsi > commands begin to timeout. It is found that TASK SET > FULL may be returned many times for the same command, >

[PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread John Garry
In high-datarate aging tests, it is found that the SCSI framework can periodically issue lu resets to the device. This is because scsi commands begin to timeout. It is found that TASK SET FULL may be returned many times for the same command, causing the timeouts. To overcome this, the queue depth

[PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread John Garry
In high-datarate aging tests, it is found that the SCSI framework can periodically issue lu resets to the device. This is because scsi commands begin to timeout. It is found that TASK SET FULL may be returned many times for the same command, causing the timeouts. To overcome this, the queue depth