Re: [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks

2015-03-04 Thread Li, Aubrey
On 2015/3/5 8:18, Rafael J. Wysocki wrote: > On Thursday, March 05, 2015 07:50:26 AM Li, Aubrey wrote: >> On 2015/2/13 0:24, Rafael J. Wysocki wrote: >>> On Thursday, February 12, 2015 02:26:43 PM Peter Zijlstra wrote: Why bother with enter_freeze() for any but the deepest state (C6 in th

Re: [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks

2015-03-04 Thread Rafael J. Wysocki
On Thursday, March 05, 2015 07:50:26 AM Li, Aubrey wrote: > On 2015/2/13 0:24, Rafael J. Wysocki wrote: > > On Thursday, February 12, 2015 02:26:43 PM Peter Zijlstra wrote: > >> > >> Why bother with enter_freeze() for any but the deepest state (C6 in this > >> case)? > > > > User space may disable

Re: [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks

2015-03-04 Thread Li, Aubrey
On 2015/2/13 0:24, Rafael J. Wysocki wrote: > On Thursday, February 12, 2015 02:26:43 PM Peter Zijlstra wrote: >> >> Why bother with enter_freeze() for any but the deepest state (C6 in this >> case)? > > User space may disable the deepest one (and any of them in general) via sysfs > and there's no

Re: [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks

2015-02-12 Thread Peter Zijlstra
On Thu, Feb 12, 2015 at 05:24:51PM +0100, Rafael J. Wysocki wrote: > On Thursday, February 12, 2015 02:26:43 PM Peter Zijlstra wrote: > > Why bother with enter_freeze() for any but the deepest state (C6 in this > > case)? > > User space may disable the deepest one (and any of them in general) via

Re: [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks

2015-02-12 Thread Rafael J. Wysocki
On Thursday, February 12, 2015 02:26:43 PM Peter Zijlstra wrote: > On Wed, Feb 11, 2015 at 05:04:17AM +0100, Rafael J. Wysocki wrote: > > @@ -131,28 +133,32 @@ static struct cpuidle_state nehalem_csta > > .flags = MWAIT2flg(0x00), > > .exit_latency = 3, > > .targ

Re: [PATCH 5/6] intel_idle: Add ->enter_freeze callbacks

2015-02-12 Thread Peter Zijlstra
On Wed, Feb 11, 2015 at 05:04:17AM +0100, Rafael J. Wysocki wrote: > @@ -131,28 +133,32 @@ static struct cpuidle_state nehalem_csta > .flags = MWAIT2flg(0x00), > .exit_latency = 3, > .target_residency = 6, > - .enter = &intel_idle }, > +

[PATCH 5/6] intel_idle: Add ->enter_freeze callbacks

2015-02-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Add an ->enter_freeze callback routine, intel_idle_freeze(), to the intel_idle driver and point the ->enter_freeze callback pointers of all of the driver's state objects to it. Signed-off-by: Rafael J. Wysocki --- drivers/idle/intel_idle.c | 179 +++