Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-29 Thread Jernej Škrabec
Dne četrtek, 12. september 2019 ob 22:26:47 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, Sep 12, 2019 at 07:51:31PM +0200, Jernej Skrabec wrote: > > + dev->regmap = devm_regmap_init_mmio(dev->dev, dev->base, > > + _regmap_config); > > + if

Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-18 Thread Maxime Ripard
Hi, On Sat, Sep 14, 2019 at 08:42:22AM +0200, Jernej Škrabec wrote: > Dne četrtek, 12. september 2019 ob 22:26:47 CEST je Maxime Ripard napisal(a): > > Hi, > > > > On Thu, Sep 12, 2019 at 07:51:31PM +0200, Jernej Skrabec wrote: > > > + dev->regmap = devm_regmap_init_mmio(dev->dev, dev->base, > >

Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-14 Thread Jernej Škrabec
Hi! Dne četrtek, 12. september 2019 ob 22:26:47 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, Sep 12, 2019 at 07:51:31PM +0200, Jernej Skrabec wrote: > > + dev->regmap = devm_regmap_init_mmio(dev->dev, dev->base, > > + _regmap_config); > > + if

Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-13 Thread Jernej Škrabec
Hi! Dne petek, 13. september 2019 ob 11:11:47 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, Sep 12, 2019 at 10:43:28PM +0200, Jernej Škrabec wrote: > > Dne četrtek, 12. september 2019 ob 22:26:47 CEST je Maxime Ripard napisal(a): > > > > + clk_set_rate(dev->mod_clk, 3); > >

Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-13 Thread Maxime Ripard
Hi, On Thu, Sep 12, 2019 at 10:43:28PM +0200, Jernej Škrabec wrote: > Dne četrtek, 12. september 2019 ob 22:26:47 CEST je Maxime Ripard napisal(a): > > > + clk_set_rate(dev->mod_clk, 3); I just realized I missed this too. If you really need the rate to be fixed, and if the controller

Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-12 Thread Jernej Škrabec
Dne četrtek, 12. september 2019 ob 22:26:47 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, Sep 12, 2019 at 07:51:31PM +0200, Jernej Skrabec wrote: > > + dev->regmap = devm_regmap_init_mmio(dev->dev, dev->base, > > + _regmap_config); > > + if

Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-12 Thread Maxime Ripard
Hi, On Thu, Sep 12, 2019 at 07:51:31PM +0200, Jernej Skrabec wrote: > + dev->regmap = devm_regmap_init_mmio(dev->dev, dev->base, > + _regmap_config); > + if (IS_ERR(dev->regmap)) { > + dev_err(dev->dev, "Couldn't create deinterlace

[PATCH 5/6] media: sun4i: Add H3 deinterlace driver

2019-09-12 Thread Jernej Skrabec
Allwinner H3 SoC contains deinterlace unit, which has several modes of operation - bypass, weave, bob and mixed (advanced) mode. I don't know how mixed mode works, but according to Allwinner it gives best results, so they use it exclusively. Currently this mode is also hardcoded here. For each