Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed 21-02-18 09:59:40, Mike Kravetz wrote: > On 02/21/2018 02:01 AM, Michal Hocko wrote: > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > Hmm, I guess I can see it. Does the following help? > > --- > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 7c204e3d132b..a963f2034dfc 100644 > >

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed 21-02-18 09:59:40, Mike Kravetz wrote: > On 02/21/2018 02:01 AM, Michal Hocko wrote: > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > Hmm, I guess I can see it. Does the following help? > > --- > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 7c204e3d132b..a963f2034dfc 100644 > >

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed 21-02-18 10:19:14, Dan Rue wrote: > On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > > [...] > > > > I bisected the failure to this commit. The problem is seen on multiple > > > >

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed 21-02-18 10:19:14, Dan Rue wrote: > On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > > [...] > > > > I bisected the failure to this commit. The problem is seen on multiple > > > >

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed, Feb 21, 2018 at 07:52:52PM +0100, Michal Hocko wrote: > On Wed 21-02-18 10:19:14, Dan Rue wrote: > > On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > > > [...] > > > > > I

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed, Feb 21, 2018 at 07:52:52PM +0100, Michal Hocko wrote: > On Wed 21-02-18 10:19:14, Dan Rue wrote: > > On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > > > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > > > [...] > > > > > I

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On 02/21/2018 02:01 AM, Michal Hocko wrote: > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > Hmm, I guess I can see it. Does the following help? > --- > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 7c204e3d132b..a963f2034dfc 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1583,7

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On 02/21/2018 02:01 AM, Michal Hocko wrote: > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > Hmm, I guess I can see it. Does the following help? > --- > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 7c204e3d132b..a963f2034dfc 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1583,7

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > [...] > > > I bisected the failure to this commit. The problem is seen on multiple > > > architectures (tested x86-64 and arm64). > > > >

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed, Feb 21, 2018 at 11:01:07AM +0100, Michal Hocko wrote: > On Wed 21-02-18 10:55:26, Michal Hocko wrote: > > On Tue 20-02-18 22:24:57, Dan Rue wrote: > [...] > > > I bisected the failure to this commit. The problem is seen on multiple > > > architectures (tested x86-64 and arm64). > > > >

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed 21-02-18 10:55:26, Michal Hocko wrote: > On Tue 20-02-18 22:24:57, Dan Rue wrote: [...] > > I bisected the failure to this commit. The problem is seen on multiple > > architectures (tested x86-64 and arm64). > > The patch shouldn't have introduced any functional changes IIRC. But let > me

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed 21-02-18 10:55:26, Michal Hocko wrote: > On Tue 20-02-18 22:24:57, Dan Rue wrote: [...] > > I bisected the failure to this commit. The problem is seen on multiple > > architectures (tested x86-64 and arm64). > > The patch shouldn't have introduced any functional changes IIRC. But let > me

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Tue 20-02-18 22:24:57, Dan Rue wrote: > On Wed, Jan 03, 2018 at 10:32:12AM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Hugetlb allocator has several layer of allocation functions depending > > and the purpose of the allocation. There are two allocators depending

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Tue 20-02-18 22:24:57, Dan Rue wrote: > On Wed, Jan 03, 2018 at 10:32:12AM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Hugetlb allocator has several layer of allocation functions depending > > and the purpose of the allocation. There are two allocators depending > > on whether

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed, Jan 03, 2018 at 10:32:12AM +0100, Michal Hocko wrote: > From: Michal Hocko > > Hugetlb allocator has several layer of allocation functions depending > and the purpose of the allocation. There are two allocators depending > on whether the page can be allocated from the

Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

On Wed, Jan 03, 2018 at 10:32:12AM +0100, Michal Hocko wrote: > From: Michal Hocko > > Hugetlb allocator has several layer of allocation functions depending > and the purpose of the allocation. There are two allocators depending > on whether the page can be allocated from the page allocator or

[PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

From: Michal Hocko Hugetlb allocator has several layer of allocation functions depending and the purpose of the allocation. There are two allocators depending on whether the page can be allocated from the page allocator or we need a contiguous allocator. This is currently

[PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

From: Michal Hocko Hugetlb allocator has several layer of allocation functions depending and the purpose of the allocation. There are two allocators depending on whether the page can be allocated from the page allocator or we need a contiguous allocator. This is currently opencoded in