Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c

2017-03-07 Thread Naveen N. Rao
On 2017/03/07 04:51PM, Masami Hiramatsu wrote: > On Tue, 7 Mar 2017 16:17:40 +0530 > "Naveen N. Rao" wrote: > > > probe-file.c needs libelf, but scanning ftrace README does not require > > that. As such, move the ftrace README scanning logic out of probe-file.c > > and into trace-event-parse.c.

Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c

2017-03-07 Thread Masami Hiramatsu
On Tue, 7 Mar 2017 16:17:40 +0530 "Naveen N. Rao" wrote: > probe-file.c needs libelf, but scanning ftrace README does not require > that. As such, move the ftrace README scanning logic out of probe-file.c > and into trace-event-parse.c. Hmm, it seems probe-file.c doesn't require libelf at all..

Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c

2017-03-07 Thread Naveen N. Rao
On 2017/03/07 03:03PM, Masami Hiramatsu wrote: > On Tue, 7 Mar 2017 16:17:40 +0530 > "Naveen N. Rao" wrote: > > > probe-file.c needs libelf, but scanning ftrace README does not require > > that. As such, move the ftrace README scanning logic out of probe-file.c > > and into trace-event-parse.c.

Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c

2017-03-07 Thread Masami Hiramatsu
On Tue, 7 Mar 2017 16:17:40 +0530 "Naveen N. Rao" wrote: > probe-file.c needs libelf, but scanning ftrace README does not require > that. As such, move the ftrace README scanning logic out of probe-file.c > and into trace-event-parse.c. As far as I can see, there is no reason to push this out f

[PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c

2017-03-07 Thread Naveen N. Rao
probe-file.c needs libelf, but scanning ftrace README does not require that. As such, move the ftrace README scanning logic out of probe-file.c and into trace-event-parse.c. Signed-off-by: Naveen N. Rao --- tools/perf/util/probe-file.c| 87 +++- tools/perf