Re: [PATCH 5/6] sched, fair: Make group power more consitent

Hi Peter, Thank you for the clarification. On 08/19/2013 04:00 PM, Peter Zijlstra wrote: > On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote: >> Hi Peter, >> >> On 08/16/2013 03:42 PM, Peter Zijlstra wrote: >> >> I have a few comments and clarification to seek. >> >> 1. How are you e

Re: [PATCH 5/6] sched, fair: Make group power more consitent

On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote: > Hi Peter, > > On 08/16/2013 03:42 PM, Peter Zijlstra wrote: > > I have a few comments and clarification to seek. > > 1. How are you ensuring from this patch that sgs->group_power does not > change over the course of load balancin

Re: [PATCH 5/6] sched, fair: Make group power more consitent

Hi Peter, On 08/16/2013 03:42 PM, Peter Zijlstra wrote: I have a few comments and clarification to seek. 1. How are you ensuring from this patch that sgs->group_power does not change over the course of load balancing? The only path to update_group_power() where sg->sgp->power gets updated,

[PATCH 5/6] sched, fair: Make group power more consitent

For easier access, less dereferences and more consisent value, store the group power in update_sg_lb_stats() and use it thereafter. The actual value in sched_group::sched_group_power::power can change throughout the load-balance pass if we're unlucky. Signed-off-by: Peter Zijlstra --- kernel/sch