Re: [PATCH 5/6] soundwire: qcom: update register read/write routine

2021-02-02 Thread Pierre-Louis Bossart
generates interrupt after it successfully finishes. This is really overhead, limiting and not really necessary unless we are doing something special. We can simply read/write the fifo that should also give exactly what we need! This will also allow to read/write registers in interrupt

Re: [PATCH 5/6] soundwire: qcom: update register read/write routine

2021-02-02 Thread Srinivas Kandagatla
On 01/02/2021 16:42, Pierre-Louis Bossart wrote: On 2/1/21 9:50 AM, Srinivas Kandagatla wrote: On 29/01/2021 19:33, Pierre-Louis Bossart wrote: On 1/29/21 11:32 AM, Srinivas Kandagatla wrote: In the existing code every soundwire register read and register write are kinda blocked.

Re: [PATCH 5/6] soundwire: qcom: update register read/write routine

2021-02-01 Thread Pierre-Louis Bossart
On 2/1/21 9:50 AM, Srinivas Kandagatla wrote: On 29/01/2021 19:33, Pierre-Louis Bossart wrote: On 1/29/21 11:32 AM, Srinivas Kandagatla wrote: In the existing code every soundwire register read and register write are kinda blocked. Each of these are using a special command id that

Re: [PATCH 5/6] soundwire: qcom: update register read/write routine

2021-02-01 Thread Srinivas Kandagatla
On 01/02/2021 14:26, Vinod Koul wrote: On 29-01-21, 17:32, Srinivas Kandagatla wrote: In the existing code every soundwire register read and register write are kinda blocked. Each of these are using a special command id that generates interrupt after it successfully finishes. This is really

Re: [PATCH 5/6] soundwire: qcom: update register read/write routine

2021-02-01 Thread Srinivas Kandagatla
On 29/01/2021 19:33, Pierre-Louis Bossart wrote: On 1/29/21 11:32 AM, Srinivas Kandagatla wrote: In the existing code every soundwire register read and register write are kinda blocked. Each of these are using a special command id that what does 'kinda blocked' mean? I meant

Re: [PATCH 5/6] soundwire: qcom: update register read/write routine

2021-02-01 Thread Vinod Koul
On 29-01-21, 17:32, Srinivas Kandagatla wrote: > In the existing code every soundwire register read and register write > are kinda blocked. Each of these are using a special command id that > generates interrupt after it successfully finishes. This is really > overhead, limiting and not really

Re: [PATCH 5/6] soundwire: qcom: update register read/write routine

2021-01-29 Thread Pierre-Louis Bossart
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote: In the existing code every soundwire register read and register write are kinda blocked. Each of these are using a special command id that what does 'kinda blocked' mean? generates interrupt after it successfully finishes. This is really

[PATCH 5/6] soundwire: qcom: update register read/write routine

2021-01-29 Thread Srinivas Kandagatla
In the existing code every soundwire register read and register write are kinda blocked. Each of these are using a special command id that generates interrupt after it successfully finishes. This is really overhead, limiting and not really necessary unless we are doing something special. We can