Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-14 Thread Linus Torvalds
On Tue, Jul 14, 2020 at 4:08 AM Christoph Hellwig wrote: > > Add helpers to wrap the get_fs/set_fs magic for undoing any damange done > by set_fs(KERNEL_DS). There is no real functional benefit, but this > documents the intent of these calls better, and will allow stubbing the > functions out

[PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-14 Thread Christoph Hellwig
Add helpers to wrap the get_fs/set_fs magic for undoing any damange done by set_fs(KERNEL_DS). There is no real functional benefit, but this documents the intent of these calls better, and will allow stubbing the functions out easily for kernels builds that do not allow address space overrides in

Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-14 Thread Christoph Hellwig
On Mon, Jul 13, 2020 at 03:19:42PM +0200, Geert Uytterhoeven wrote: > > This used to set KERNEL_DS, and now it sets USER_DS, which looks wrong > > superficially. > > Thanks for noticing, and sorry for missing that myself. > > The same issue is present for SuperH: > > -

Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-13 Thread Geert Uytterhoeven
Hi Mark, On Mon, Jul 13, 2020 at 2:21 PM Mark Rutland wrote: > On Fri, Jul 10, 2020 at 03:57:05PM +0200, Christoph Hellwig wrote: > > Add helpers to wraper the get_fs/set_fs magic for undoing any damange > > done by set_fs(KERNEL_DS). There is no real functional benefit, but this > > documents

Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-13 Thread Mark Rutland
On Fri, Jul 10, 2020 at 03:57:05PM +0200, Christoph Hellwig wrote: > Add helpers to wraper the get_fs/set_fs magic for undoing any damange > done by set_fs(KERNEL_DS). There is no real functional benefit, but this > documents the intent of these calls better, and will allow stubbing the >

Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-13 Thread Mark Rutland
On Fri, Jul 10, 2020 at 03:57:05PM +0200, Christoph Hellwig wrote: > Add helpers to wraper the get_fs/set_fs magic for undoing any damange > done by set_fs(KERNEL_DS). There is no real functional benefit, but this > documents the intent of these calls better, and will allow stubbing the >

Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-13 Thread Greentime Hu
Christoph Hellwig 於 2020年7月10日 週五 下午9:57寫道: > > Add helpers to wraper the get_fs/set_fs magic for undoing any damange > done by set_fs(KERNEL_DS). There is no real functional benefit, but this > documents the intent of these calls better, and will allow stubbing the > functions out easily for

Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-13 Thread Geert Uytterhoeven
On Fri, Jul 10, 2020 at 3:57 PM Christoph Hellwig wrote: > Add helpers to wraper the get_fs/set_fs magic for undoing any damage to wrap > done by set_fs(KERNEL_DS). There is no real functional benefit, but this > documents the intent of these calls better, and will allow stubbing the >

[PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers

2020-07-10 Thread Christoph Hellwig
Add helpers to wraper the get_fs/set_fs magic for undoing any damange done by set_fs(KERNEL_DS). There is no real functional benefit, but this documents the intent of these calls better, and will allow stubbing the functions out easily for kernels builds that do not allow address space overrides