Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Anton Vorontsov
On Thu, Apr 12, 2007 at 06:20:23PM +0400, Evgeniy Polyakov wrote: > On Thu, Apr 12, 2007 at 06:08:07PM +0400, Anton Vorontsov ([EMAIL PROTECTED]) > wrote: > > > > +int w1_ds2760_read(struct device *dev, char *buf, int addr, size_t > > > > count) > > > > +{ > > > > + return

Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Evgeniy Polyakov
On Thu, Apr 12, 2007 at 06:08:07PM +0400, Anton Vorontsov ([EMAIL PROTECTED]) wrote: > > > +int w1_ds2760_read(struct device *dev, char *buf, int addr, size_t count) > > > +{ > > > + return w1_ds2760_io(dev, buf, addr, count, 0); > > > +} > > > + > > > +int w1_ds2760_write(struct device *dev,

Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Anton Vorontsov
Hello Evgeniy, On Thu, Apr 12, 2007 at 11:08:54AM +0400, Evgeniy Polyakov wrote: > On Thu, Apr 12, 2007 at 03:25:17AM +0400, Anton Vorontsov ([EMAIL PROTECTED]) > wrote: > > This is W1 slave for ds2760 chip, found inside almost every HP iPaq and > > HTC PDAs/phones. > > Hi Anton, I have some

Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Evgeniy Polyakov
On Thu, Apr 12, 2007 at 03:25:17AM +0400, Anton Vorontsov ([EMAIL PROTECTED]) wrote: > This is W1 slave for ds2760 chip, found inside almost every HP iPaq and > HTC PDAs/phones. Hi Anton, I have some cleanup-related comments, patch itself looks good. > diff --git a/drivers/w1/slaves/w1_ds2760.c

Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Evgeniy Polyakov
On Thu, Apr 12, 2007 at 03:25:17AM +0400, Anton Vorontsov ([EMAIL PROTECTED]) wrote: This is W1 slave for ds2760 chip, found inside almost every HP iPaq and HTC PDAs/phones. Hi Anton, I have some cleanup-related comments, patch itself looks good. diff --git a/drivers/w1/slaves/w1_ds2760.c

Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Anton Vorontsov
Hello Evgeniy, On Thu, Apr 12, 2007 at 11:08:54AM +0400, Evgeniy Polyakov wrote: On Thu, Apr 12, 2007 at 03:25:17AM +0400, Anton Vorontsov ([EMAIL PROTECTED]) wrote: This is W1 slave for ds2760 chip, found inside almost every HP iPaq and HTC PDAs/phones. Hi Anton, I have some

Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Evgeniy Polyakov
On Thu, Apr 12, 2007 at 06:08:07PM +0400, Anton Vorontsov ([EMAIL PROTECTED]) wrote: +int w1_ds2760_read(struct device *dev, char *buf, int addr, size_t count) +{ + return w1_ds2760_io(dev, buf, addr, count, 0); +} + +int w1_ds2760_write(struct device *dev, char *buf, int addr,

Re: [PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-12 Thread Anton Vorontsov
On Thu, Apr 12, 2007 at 06:20:23PM +0400, Evgeniy Polyakov wrote: On Thu, Apr 12, 2007 at 06:08:07PM +0400, Anton Vorontsov ([EMAIL PROTECTED]) wrote: +int w1_ds2760_read(struct device *dev, char *buf, int addr, size_t count) +{ + return w1_ds2760_io(dev, buf, addr,

[PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-11 Thread Anton Vorontsov
This is W1 slave for ds2760 chip, found inside almost every HP iPaq and HTC PDAs/phones. --- drivers/w1/slaves/Kconfig | 13 +++ drivers/w1/slaves/Makefile|1 + drivers/w1/slaves/w1_ds2760.c | 162 + drivers/w1/slaves/w1_ds2760.h | 52

[PATCH 5/7] [RFC] ds2760 W1 slave

2007-04-11 Thread Anton Vorontsov
This is W1 slave for ds2760 chip, found inside almost every HP iPaq and HTC PDAs/phones. --- drivers/w1/slaves/Kconfig | 13 +++ drivers/w1/slaves/Makefile|1 + drivers/w1/slaves/w1_ds2760.c | 162 + drivers/w1/slaves/w1_ds2760.h | 52