Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures

2016-10-25 Thread Mark Brown
On Tue, Oct 25, 2016 at 07:55:00AM +0200, Julia Lawall wrote: > On Mon, 24 Oct 2016, Mark Brown wrote: > > You split out a few drivers as separate patches but not these ones - > > what's special about these ones? > If it's preferred, I could send them all one file at a time, or when the > maintai

Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures

2016-10-25 Thread Julia Lawall
On Tue, 25 Oct 2016, Joe Perches wrote: > On Tue, 2016-10-25 at 07:55 +0200, Julia Lawall wrote: > > On Mon, 24 Oct 2016, Mark Brown wrote: > > > On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote: > > > > --- > > > > sound/soc/generic/simple-card.c |2 +- > [...] >

Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures

2016-10-25 Thread Joe Perches
On Tue, 2016-10-25 at 07:55 +0200, Julia Lawall wrote: > On Mon, 24 Oct 2016, Mark Brown wrote: > > On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote: > > > --- > > > sound/soc/generic/simple-card.c |2 +- [...] > > > sound/soc/mxs/mxs-sgtl5000.c|

Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures

2016-10-24 Thread Julia Lawall
On Mon, 24 Oct 2016, Mark Brown wrote: > On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote: > > > --- > > sound/soc/generic/simple-card.c |2 +- > > sound/soc/generic/simple-scu-card.c |2 +- > > sound/soc/intel/boards/bdw-rt5677.c |

Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures

2016-10-24 Thread Julia Lawall
On Mon, 24 Oct 2016, Mark Brown wrote: > On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote: > > > --- > > sound/soc/generic/simple-card.c |2 +- > > sound/soc/generic/simple-scu-card.c |2 +- > > sound/soc/intel/boards/bdw-rt5677.c |

Re: [PATCH 5/7] ASoC: constify snd_soc_ops structures

2016-10-24 Thread Mark Brown
On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote: > --- > sound/soc/generic/simple-card.c |2 +- > sound/soc/generic/simple-scu-card.c |2 +- > sound/soc/intel/boards/bdw-rt5677.c |2 +- > sound/soc/intel/boards/bxt_da7219_max98357a.

[PATCH 5/7] ASoC: constify snd_soc_ops structures

2016-10-15 Thread Julia Lawall
Check for snd_soc_ops structures that are only stored in the ops field of a snd_soc_dai_link structure. This field is declared const, so snd_soc_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.f