Re: [PATCH 5/7] arm64: keep .altinstructions and .altinstr_replacement

2017-11-30 Thread Nicholas Piggin
On Thu, 30 Nov 2017 09:00:35 -0800 Nick Desaulniers wrote: > On Wed, Nov 29, 2017 at 5:58 PM, Nicholas Piggin wrote: > > (Comparing `readelf -S` before/after is a way to spot bugs.) > > Do you have a script that can be used to diff 2 `readelf -S`, look for > missing references, and report an

Re: [PATCH 5/7] arm64: keep .altinstructions and .altinstr_replacement

2017-11-30 Thread Sami Tolvanen
On Thu, Nov 30, 2017 at 11:58:27AM +1000, Nicholas Piggin wrote: > So yes please if it's not too much trouble, could you remove > the "gold" name from the generic patch and put it at the front > of the series with this arm64 patch. Sure, I'll do this in v2. > Possibly then you could also do a 3rd

Re: [PATCH 5/7] arm64: keep .altinstructions and .altinstr_replacement

2017-11-30 Thread Nick Desaulniers
On Wed, Nov 29, 2017 at 5:58 PM, Nicholas Piggin wrote: > (Comparing `readelf -S` before/after is a way to spot bugs.) Do you have a script that can be used to diff 2 `readelf -S`, look for missing references, and report an error? Might be easier to rerun that every so often and see what's missin

Re: [PATCH 5/7] arm64: keep .altinstructions and .altinstr_replacement

2017-11-29 Thread Nicholas Piggin
On Wed, 29 Nov 2017 15:57:53 -0800 Nick Desaulniers wrote: > On Wed, Nov 29, 2017 at 3:44 PM, Sami Tolvanen > wrote: > > Make sure the linker doesn't remove .altinstructions or > > .altinstr_replacement when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is > > enabled. > > This sounds like a bug in t

Re: [PATCH 5/7] arm64: keep .altinstructions and .altinstr_replacement

2017-11-29 Thread Nick Desaulniers
On Wed, Nov 29, 2017 at 3:44 PM, Sami Tolvanen wrote: > Make sure the linker doesn't remove .altinstructions or > .altinstr_replacement when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is > enabled. This sounds like a bug in the original implementation of CONFIG_LD_DEAD_CODE_DATA_ELIMINATION? If so, thi

[PATCH 5/7] arm64: keep .altinstructions and .altinstr_replacement

2017-11-29 Thread Sami Tolvanen
Make sure the linker doesn't remove .altinstructions or .altinstr_replacement when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled. Signed-off-by: Sami Tolvanen --- arch/arm64/kernel/vmlinux.lds.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/vmlinux.l