Re: [PATCH 5/7] selftests/x86: fix cross build logic

Hi Andy, On 14 April 2015 at 17:33, Andy Lutomirski wrote: > On 04/14/2015 03:52 PM, Tyler Baker wrote: >> >> x86 tests should not be built when ARCH != x86. Reused the logic from >> breakpoints to determine when it's appropriate to build. > > > In the future, please cc the author of

Re: [PATCH 5/7] selftests/x86: fix cross build logic

On 04/14/2015 03:52 PM, Tyler Baker wrote: x86 tests should not be built when ARCH != x86. Reused the logic from breakpoints to determine when it's appropriate to build. In the future, please cc the author of recently-written code that you're fixing :) This patch is really weird. You're

[PATCH 5/7] selftests/x86: fix cross build logic

x86 tests should not be built when ARCH != x86. Reused the logic from breakpoints to determine when it's appropriate to build. Signed-off-by: Tyler Baker --- tools/testing/selftests/x86/Makefile | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff

Re: [PATCH 5/7] selftests/x86: fix cross build logic

On 04/14/2015 03:52 PM, Tyler Baker wrote: x86 tests should not be built when ARCH != x86. Reused the logic from breakpoints to determine when it's appropriate to build. In the future, please cc the author of recently-written code that you're fixing :) This patch is really weird. You're

Re: [PATCH 5/7] selftests/x86: fix cross build logic

Hi Andy, On 14 April 2015 at 17:33, Andy Lutomirski l...@amacapital.net wrote: On 04/14/2015 03:52 PM, Tyler Baker wrote: x86 tests should not be built when ARCH != x86. Reused the logic from breakpoints to determine when it's appropriate to build. In the future, please cc the author of

[PATCH 5/7] selftests/x86: fix cross build logic

x86 tests should not be built when ARCH != x86. Reused the logic from breakpoints to determine when it's appropriate to build. Signed-off-by: Tyler Baker tyler.ba...@linaro.org --- tools/testing/selftests/x86/Makefile | 35 +++ 1 file changed, 23 insertions(+), 12