Re: [PATCH 5/7] uprobes/x86: Gather "riprel" functions together

2014-04-03 Thread Oleg Nesterov
On 04/02, Jim Keniston wrote: > > On Mon, 2014-03-31 at 21:44 +0200, Oleg Nesterov wrote: > ... > > +static void > > +handle_riprel_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs, > > long *correction) > > +{ > > + if (auprobe->fixups & (UPROBE_FIX_RIP_AX | UPROBE_FIX_RIP_CX)) { > >

Re: [PATCH 5/7] uprobes/x86: Gather "riprel" functions together

2014-04-02 Thread Jim Keniston
On Mon, 2014-03-31 at 21:44 +0200, Oleg Nesterov wrote: ... > +static void > +handle_riprel_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs, > long *correction) > +{ > + if (auprobe->fixups & (UPROBE_FIX_RIP_AX | UPROBE_FIX_RIP_CX)) { > + struct arch_uprobe_task *autask;

Re: [PATCH 5/7] uprobes/x86: Gather "riprel" functions together

2014-03-31 Thread Masami Hiramatsu
(2014/04/01 4:44), Oleg Nesterov wrote: > Cosmetic. Move pre_xol_rip_insn() and handle_riprel_post_xol() up > to the closely related handle_riprel_insn(). > > This way it is simpler to read and understand this code, and this > lessens the number of ifdef's. > > TODO: rename them somehow to make t

[PATCH 5/7] uprobes/x86: Gather "riprel" functions together

2014-03-31 Thread Oleg Nesterov
Cosmetic. Move pre_xol_rip_insn() and handle_riprel_post_xol() up to the closely related handle_riprel_insn(). This way it is simpler to read and understand this code, and this lessens the number of ifdef's. TODO: rename them somehow to make the naming consistent. Signed-off-by: Oleg Nesterov -