Re: [PATCH 5/7] uprobes: Introduce uprobe_copy_insn()

2012-10-07 Thread Srikar Dronamraju
* Oleg Nesterov [2012-10-06 20:59:49]: > On 10/06, Srikar Dronamraju wrote: > > > > Yeah prepare_uprobe() looks good for me. > > > > Acked-by: Srikar Dronamraju > > OK, renamed. > > The next patches updated accordinly, I hope I can keep your acks. Yes, please keep my acks as I understand that

Re: [PATCH 5/7] uprobes: Introduce uprobe_copy_insn()

2012-10-06 Thread Oleg Nesterov
On 10/06, Srikar Dronamraju wrote: > > Yeah prepare_uprobe() looks good for me. > > Acked-by: Srikar Dronamraju OK, renamed. The next patches updated accordinly, I hope I can keep your acks. -- [PATCH] uprobes: Introduc

Re: [PATCH 5/7] uprobes: Introduce uprobe_copy_insn()

2012-10-06 Thread Srikar Dronamraju
he patch again. Yeah prepare_uprobe() looks good for me. Acked-by: Srikar Dronamraju > > ================== > [PATCH 5/7] uprobes: Introduce uprobe_copy_insn() > > Preparation. Extract the copy_insn/arch_uprobe_analy

Re: [PATCH 5/7] uprobes: Introduce uprobe_copy_insn()

2012-10-06 Thread Oleg Nesterov
only extern functions start with uprobe_ but we already have > copy_insn, and __copy_insn, So can think of any names for > uprobe_copy_insn. Yes ;) plus it is not only "copy", it does _analyze > Not sure test_and_copy_insn() is a good alternative. perhaps prepare_u

Re: [PATCH 5/7] uprobes: Introduce uprobe_copy_insn()

2012-10-06 Thread Srikar Dronamraju
* Oleg Nesterov [2012-09-30 21:42:17]: > Preparation. Extract the copy_insn/arch_uprobe_analyze_insn code > from install_breakpoint() into the new helper, uprobe_copy_insn(). > > And move uprobe->flags defines from uprobes.h to uprobes.c, nobody > else can use them anyway. > > Signed-off-by: Ol

[PATCH 5/7] uprobes: Introduce uprobe_copy_insn()

2012-09-30 Thread Oleg Nesterov
Preparation. Extract the copy_insn/arch_uprobe_analyze_insn code from install_breakpoint() into the new helper, uprobe_copy_insn(). And move uprobe->flags defines from uprobes.h to uprobes.c, nobody else can use them anyway. Signed-off-by: Oleg Nesterov --- include/linux/uprobes.h | 10 --