Re: [PATCH 5/8] block: introduce blk_flush_queue to drive flush machinery

2014-09-09 Thread Ming Lei
On Wed, Sep 10, 2014 at 2:55 AM, Jens Axboe wrote: > On 09/09/2014 12:43 PM, Christoph Hellwig wrote: >> On Tue, Sep 09, 2014 at 09:05:46PM +0800, Ming Lei wrote: >>> This patch introduces 'struct blk_flush_queue' and puts all >>> flush machinery related stuff into this strcuture, so that >> >> s/

Re: [PATCH 5/8] block: introduce blk_flush_queue to drive flush machinery

2014-09-09 Thread Ming Lei
On Wed, Sep 10, 2014 at 2:43 AM, Christoph Hellwig wrote: > On Tue, Sep 09, 2014 at 09:05:46PM +0800, Ming Lei wrote: >> This patch introduces 'struct blk_flush_queue' and puts all >> flush machinery related stuff into this strcuture, so that > > s/stuff/fields/ > s/strcuture/structure/ > > Looks

Re: [PATCH 5/8] block: introduce blk_flush_queue to drive flush machinery

2014-09-09 Thread Jens Axboe
On 09/09/2014 12:43 PM, Christoph Hellwig wrote: > On Tue, Sep 09, 2014 at 09:05:46PM +0800, Ming Lei wrote: >> This patch introduces 'struct blk_flush_queue' and puts all >> flush machinery related stuff into this strcuture, so that > > s/stuff/fields/ > s/strcuture/structure/ > > Looks good, bu

Re: [PATCH 5/8] block: introduce blk_flush_queue to drive flush machinery

2014-09-09 Thread Christoph Hellwig
On Tue, Sep 09, 2014 at 09:05:46PM +0800, Ming Lei wrote: > This patch introduces 'struct blk_flush_queue' and puts all > flush machinery related stuff into this strcuture, so that s/stuff/fields/ s/strcuture/structure/ Looks good, but a few more nitpicks below. Reviewed-by: Christoph Hellwig

[PATCH 5/8] block: introduce blk_flush_queue to drive flush machinery

2014-09-09 Thread Ming Lei
This patch introduces 'struct blk_flush_queue' and puts all flush machinery related stuff into this strcuture, so that - flush implementation details aren't exposed to driver - it is easy to convert to per dispatch-queue flush machinery This patch is basically a mechanical replace