Re: [PATCH 5/8] mfd: Add ST's Low Power Controller driver

2014-12-15 Thread Lee Jones
On Mon, 15 Dec 2014, Arnd Bergmann wrote: > On Monday 15 December 2014 13:50:52 Lee Jones wrote: > > > > > > > > > > I don't think it's necessary to have the MFD node if only one of the > > > two modes can be used based on a DT property. It should be enough > > > to have both the rtc and the wdt

Re: [PATCH 5/8] mfd: Add ST's Low Power Controller driver

2014-12-15 Thread Arnd Bergmann
On Monday 15 December 2014 13:50:52 Lee Jones wrote: > > > > > > > I don't think it's necessary to have the MFD node if only one of the > > two modes can be used based on a DT property. It should be enough > > to have both the rtc and the wdt driver list the same compatible > > string and check t

Re: [PATCH 5/8] mfd: Add ST's Low Power Controller driver

2014-12-15 Thread Lee Jones
On Mon, 15 Dec 2014, Arnd Bergmann wrote: > On Monday 15 December 2014 11:25:35 Lee Jones wrote: > > + ret = of_property_read_u32(np, "st,lpc-mode", &mode); > > + if (ret) { > > + dev_err(&pdev->dev, "An LPC mode must be selected\n"); > > + return ret; > > +

Re: [PATCH 5/8] mfd: Add ST's Low Power Controller driver

2014-12-15 Thread Arnd Bergmann
On Monday 15 December 2014 11:25:35 Lee Jones wrote: > + ret = of_property_read_u32(np, "st,lpc-mode", &mode); > + if (ret) { > + dev_err(&pdev->dev, "An LPC mode must be selected\n"); > + return ret; > + } > + > + switch (mode) { > + case S

[PATCH 5/8] mfd: Add ST's Low Power Controller driver

2014-12-15 Thread Lee Jones
On current ST platforms the LPC controls a number of functions. This patch enables possible support for the LPC Watchdog and LPC RTC devices and ensures only one of them operates at any one time. Signed-off-by: Lee Jones --- drivers/mfd/Kconfig | 8 + drivers/mfd/Makefile | 1 + drivers/