Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-24 Thread Pali Rohár
On Thursday 23 July 2015 23:36:24 Belisko Marek wrote: > On Thu, Jul 23, 2015 at 11:15 PM, Pali Rohár wrote: > > On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: > >> Hi Pali, > >> > >> On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár > >> wrote: > >> > On Thursday 23 July 2015 19:03:08 Andrew

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-24 Thread Pali Rohár
On Thursday 23 July 2015 23:36:24 Belisko Marek wrote: On Thu, Jul 23, 2015 at 11:15 PM, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: Hi Pali, On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 23 July

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Belisko Marek
On Thu, Jul 23, 2015 at 11:15 PM, Pali Rohár wrote: > On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: >> Hi Pali, >> >> On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár >> wrote: >> > On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: >> >> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C >> >> >>

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: > Hi Pali, > > On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár > wrote: > > On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: > >> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C > >> >> -MODULE_ALIAS("i2c:bq27000-battery"); > >> >> +#ifdef

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Belisko Marek
Hi Pali, On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár wrote: > On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: >> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C >> >> -MODULE_ALIAS("i2c:bq27000-battery"); >> >> +#ifdef CONFIG_BATTERY_BQ27XXX_I2C >> >> +MODULE_ALIAS("i2c:bq27xxx-battery"); >> >>

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: > >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C > >> -MODULE_ALIAS("i2c:bq27000-battery"); > >> +#ifdef CONFIG_BATTERY_BQ27XXX_I2C > >> +MODULE_ALIAS("i2c:bq27xxx-battery"); > >> > >> #endif > > > > Why is this MODULE_ALIAS needed? Some lines

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Wednesday 22 July 2015 16:51:57 Andrew F. Davis wrote: > Rename functions that are used by multiple devices. New devices > have been added and the function names and driver name are no longer > general enough for the functionality they provide. > > Signed-off-by: Andrew F. Davis > --- >

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: -#ifdef CONFIG_BATTERY_BQ27X00_I2C -MODULE_ALIAS(i2c:bq27000-battery); +#ifdef CONFIG_BATTERY_BQ27XXX_I2C +MODULE_ALIAS(i2c:bq27xxx-battery); #endif Why is this MODULE_ALIAS needed? Some lines upper there is

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: Hi Pali, On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: -#ifdef CONFIG_BATTERY_BQ27X00_I2C -MODULE_ALIAS(i2c:bq27000-battery); +#ifdef

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Belisko Marek
On Thu, Jul 23, 2015 at 11:15 PM, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 23 July 2015 22:56:26 Belisko Marek wrote: Hi Pali, On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: -#ifdef

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Belisko Marek
Hi Pali, On Thu, Jul 23, 2015 at 10:15 PM, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote: -#ifdef CONFIG_BATTERY_BQ27X00_I2C -MODULE_ALIAS(i2c:bq27000-battery); +#ifdef CONFIG_BATTERY_BQ27XXX_I2C +MODULE_ALIAS(i2c:bq27xxx-battery);

Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-23 Thread Pali Rohár
On Wednesday 22 July 2015 16:51:57 Andrew F. Davis wrote: Rename functions that are used by multiple devices. New devices have been added and the function names and driver name are no longer general enough for the functionality they provide. Signed-off-by: Andrew F. Davis a...@ti.com ---

[PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-22 Thread Andrew F. Davis
Rename functions that are used by multiple devices. New devices have been added and the function names and driver name are no longer general enough for the functionality they provide. Signed-off-by: Andrew F. Davis --- MAINTAINERS| 4 +-

[PATCH 5/8] power: bq27x00_battery: Renaming for consistency

2015-07-22 Thread Andrew F. Davis
Rename functions that are used by multiple devices. New devices have been added and the function names and driver name are no longer general enough for the functionality they provide. Signed-off-by: Andrew F. Davis a...@ti.com --- MAINTAINERS| 4 +-