Re: [PATCH 5/8] sched/fair: Make check_misfit_status() only compare dynamic capacities

2021-02-04 Thread Dietmar Eggemann
On 04/02/2021 12:34, Valentin Schneider wrote: > On 04/02/21 11:49, Dietmar Eggemann wrote: >> On 03/02/2021 16:15, Qais Yousef wrote: >>> On 01/28/21 18:31, Valentin Schneider wrote: [...] > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 21bd71f58c06..ea7f0155e268 100644 > ---

Re: [PATCH 5/8] sched/fair: Make check_misfit_status() only compare dynamic capacities

2021-02-04 Thread Valentin Schneider
On 04/02/21 11:49, Dietmar Eggemann wrote: > On 03/02/2021 16:15, Qais Yousef wrote: >> On 01/28/21 18:31, Valentin Schneider wrote: > > [...] > >>> @@ -10238,7 +10236,7 @@ static void nohz_balancer_kick(struct rq *rq) >>> * When ASYM_CPUCAPACITY; see if there's a higher capacity CPU >

Re: [PATCH 5/8] sched/fair: Make check_misfit_status() only compare dynamic capacities

2021-02-04 Thread Dietmar Eggemann
On 03/02/2021 16:15, Qais Yousef wrote: > On 01/28/21 18:31, Valentin Schneider wrote: [...] >> @@ -10238,7 +10236,7 @@ static void nohz_balancer_kick(struct rq *rq) >> * When ASYM_CPUCAPACITY; see if there's a higher capacity CPU >> * to run the misfit task on. >>

Re: [PATCH 5/8] sched/fair: Make check_misfit_status() only compare dynamic capacities

2021-02-03 Thread Qais Yousef
On 01/28/21 18:31, Valentin Schneider wrote: > check_misfit_status() checks for both capacity pressure & available CPUs > with higher capacity. Now that we have a sane(ish) capacity comparison > margin which is used throughout load-balance, this can be condensed into a > single check: > > capaci

[PATCH 5/8] sched/fair: Make check_misfit_status() only compare dynamic capacities

2021-01-28 Thread Valentin Schneider
check_misfit_status() checks for both capacity pressure & available CPUs with higher capacity. Now that we have a sane(ish) capacity comparison margin which is used throughout load-balance, this can be condensed into a single check: capacity_greater(, ); This has the added benefit of returning