Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-21 Thread Mark Einon
On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote: > Hi Mark, > > On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote: > > > > > Hi Fabio, thanks for the review. > > > > It's a space alignment of parameters to go with the previous change, to > > keep wrapping consistent in the file: >

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-21 Thread Fabio Estevam
Hi Mark, On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote: > > Hi Fabio, thanks for the review. > > It's a space alignment of parameters to go with the previous change, to > keep wrapping consistent in the file: > > - while (i2c_wack) { > + while (1) { > if

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-21 Thread Mark Einon
On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote: > On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon wrote: > > > do { > > pci_read_config_dword(pdev, > > - LBCIF_DATA_REGISTER, ); > > +

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-21 Thread Mark Einon
On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote: On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon mark.ei...@gmail.com wrote: do { pci_read_config_dword(pdev, - LBCIF_DATA_REGISTER,

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-21 Thread Fabio Estevam
Hi Mark, On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon mark.ei...@gmail.com wrote: Hi Fabio, thanks for the review. It's a space alignment of parameters to go with the previous change, to keep wrapping consistent in the file: - while (i2c_wack) { + while (1) {

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-21 Thread Mark Einon
On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote: Hi Mark, On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon mark.ei...@gmail.com wrote: Hi Fabio, thanks for the review. It's a space alignment of parameters to go with the previous change, to keep wrapping consistent in the

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-20 Thread Fabio Estevam
On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon wrote: > do { > pci_read_config_dword(pdev, > - LBCIF_DATA_REGISTER, ); > + LBCIF_DATA_REGISTER, > +

[PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-20 Thread Mark Einon
i2c_wack is only used to implement a while(1) loop, so let's remove it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index

[PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-20 Thread Mark Einon
i2c_wack is only used to implement a while(1) loop, so let's remove it. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

2014-08-20 Thread Fabio Estevam
On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon mark.ei...@gmail.com wrote: do { pci_read_config_dword(pdev, - LBCIF_DATA_REGISTER, val); +