Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-16 Thread Daniel Lezcano
Hi Viresh, sorry for the late reply. On 09/02/2018 10:41, Viresh Kumar wrote: > On 07-02-18, 11:34, Daniel Lezcano wrote: >> On 07/02/2018 10:12, Viresh Kumar wrote: >>> What about cpuidle_cooling_unregister() ? >> >> The unregister function is not needed because cpuidle can't be unloaded. >> T

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-09 Thread Viresh Kumar
On 07-02-18, 11:34, Daniel Lezcano wrote: > On 07/02/2018 10:12, Viresh Kumar wrote: > > What about cpuidle_cooling_unregister() ? > > The unregister function is not needed because cpuidle can't be unloaded. > The cpuidle cooling device is registered after the cpuidle successfully > initialized it

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-07 Thread Viresh Kumar
On 07-02-18, 11:34, Daniel Lezcano wrote: > Ok, I thought I tried the different combinations but I will double check. You perhaps tried after the combo patch. Try after this one :) -- viresh

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-07 Thread Daniel Lezcano
Hi Viresh, thanks for reviewing. On 07/02/2018 10:12, Viresh Kumar wrote: > On 23-01-18, 16:34, Daniel Lezcano wrote: >> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > >> +/** >> + * cpuidle_cooling_ops - thermal cooling device ops >> + */ >> +static struct thermal

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-07 Thread Viresh Kumar
On 23-01-18, 16:34, Daniel Lezcano wrote: > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > +/** > + * cpuidle_cooling_ops - thermal cooling device ops > + */ > +static struct thermal_cooling_device_ops cpuidle_cooling_ops = { > + .get_max_state = cpuidle_cooling_g

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-06 Thread Daniel Lezcano
On 05/02/2018 14:54, Daniel Thompson wrote: > On 23/01/18 15:34, Daniel Lezcano wrote: >> +/** >> + * cpuidle_cooling_get_max_state - Get the maximum state >> + * @cdev  : the thermal cooling device >> + * @state : a pointer to the state variable to be filled >> + * >> + * The function gives always

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-05 Thread Daniel Thompson
On 23/01/18 15:34, Daniel Lezcano wrote: +/** + * cpuidle_cooling_get_max_state - Get the maximum state + * @cdev : the thermal cooling device + * @state : a pointer to the state variable to be filled + * + * The function gives always 100 as the injection ratio is percentile + * based for consis

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-02-01 Thread Daniel Lezcano
On 01/02/2018 08:57, Vincent Guittot wrote: > On 31 January 2018 at 16:27, Daniel Lezcano wrote: >> On 31/01/2018 10:56, Vincent Guittot wrote: >>> On 31 January 2018 at 10:50, Daniel Lezcano >>> wrote: On 31/01/2018 10:46, Vincent Guittot wrote: > On 31 January 2018 at 10:33, Daniel Le

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-31 Thread Vincent Guittot
On 31 January 2018 at 16:27, Daniel Lezcano wrote: > On 31/01/2018 10:56, Vincent Guittot wrote: >> On 31 January 2018 at 10:50, Daniel Lezcano >> wrote: >>> On 31/01/2018 10:46, Vincent Guittot wrote: On 31 January 2018 at 10:33, Daniel Lezcano wrote: > On 31/01/2018 10:01, Vinc

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-31 Thread Daniel Lezcano
On 31/01/2018 10:56, Vincent Guittot wrote: > On 31 January 2018 at 10:50, Daniel Lezcano wrote: >> On 31/01/2018 10:46, Vincent Guittot wrote: >>> On 31 January 2018 at 10:33, Daniel Lezcano >>> wrote: On 31/01/2018 10:01, Vincent Guittot wrote: > Hi Daniel, > > On 23 January 2

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-31 Thread Vincent Guittot
On 31 January 2018 at 10:50, Daniel Lezcano wrote: > On 31/01/2018 10:46, Vincent Guittot wrote: >> On 31 January 2018 at 10:33, Daniel Lezcano >> wrote: >>> On 31/01/2018 10:01, Vincent Guittot wrote: Hi Daniel, On 23 January 2018 at 16:34, Daniel Lezcano wrote: >>> >>> [

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-31 Thread Daniel Lezcano
On 31/01/2018 10:46, Vincent Guittot wrote: > On 31 January 2018 at 10:33, Daniel Lezcano wrote: >> On 31/01/2018 10:01, Vincent Guittot wrote: >>> Hi Daniel, >>> >>> On 23 January 2018 at 16:34, Daniel Lezcano >>> wrote: >> >> [ ... ] (please trim :) >> + /* +

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-31 Thread Vincent Guittot
On 31 January 2018 at 10:33, Daniel Lezcano wrote: > On 31/01/2018 10:01, Vincent Guittot wrote: >> Hi Daniel, >> >> On 23 January 2018 at 16:34, Daniel Lezcano >> wrote: > > [ ... ] (please trim :) > >>> + /* >>> +* Each cooling device is per package. Each package

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-31 Thread Daniel Lezcano
On 31/01/2018 10:01, Vincent Guittot wrote: > Hi Daniel, > > On 23 January 2018 at 16:34, Daniel Lezcano wrote: [ ... ] (please trim :) >> + /* >> +* Each cooling device is per package. Each package >> +* has a set of cpus where the physical number

Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-31 Thread Vincent Guittot
Hi Daniel, On 23 January 2018 at 16:34, Daniel Lezcano wrote: > The cpu idle cooling driver performs synchronized idle injection across all > cpus belonging to the same cluster and offers a new method to cool down a SoC. > > Each cluster has its own idle cooling device, each core has its own idle

[PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-01-23 Thread Daniel Lezcano
The cpu idle cooling driver performs synchronized idle injection across all cpus belonging to the same cluster and offers a new method to cool down a SoC. Each cluster has its own idle cooling device, each core has its own idle injection thread, each idle injection thread uses play_idle to enter i