Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-22 Thread Boris Ostrovsky
On 02/19/2016 07:42 PM, Luis R. Rodriguez wrote: On Fri, Feb 19, 2016 at 05:17:27PM -0500, Boris Ostrovsky wrote: On 02/19/2016 03:58 PM, Luis R. Rodriguez wrote: On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: in xen_start_kernel(). Better yet, clear whole .bss. (This

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-22 Thread Boris Ostrovsky
On 02/19/2016 07:42 PM, Luis R. Rodriguez wrote: On Fri, Feb 19, 2016 at 05:17:27PM -0500, Boris Ostrovsky wrote: On 02/19/2016 03:58 PM, Luis R. Rodriguez wrote: On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: in xen_start_kernel(). Better yet, clear whole .bss. (This

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Luis R. Rodriguez
On Fri, Feb 19, 2016 at 05:17:27PM -0500, Boris Ostrovsky wrote: > > > On 02/19/2016 03:58 PM, Luis R. Rodriguez wrote: > >On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: > > > >>in xen_start_kernel(). Better yet, clear whole .bss. > >> > >>(This applies to the next patch as

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Luis R. Rodriguez
On Fri, Feb 19, 2016 at 05:17:27PM -0500, Boris Ostrovsky wrote: > > > On 02/19/2016 03:58 PM, Luis R. Rodriguez wrote: > >On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: > > > >>in xen_start_kernel(). Better yet, clear whole .bss. > >> > >>(This applies to the next patch as

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Boris Ostrovsky
On 02/19/2016 03:58 PM, Luis R. Rodriguez wrote: On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: in xen_start_kernel(). Better yet, clear whole .bss. (This applies to the next patch as well). So clear_bss() -- oh look, another call that xen_start_kernel() could have made

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Boris Ostrovsky
On 02/19/2016 03:58 PM, Luis R. Rodriguez wrote: On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: in xen_start_kernel(). Better yet, clear whole .bss. (This applies to the next patch as well). So clear_bss() -- oh look, another call that xen_start_kernel() could have made

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Luis R. Rodriguez
On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: > > > On 02/19/2016 08:08 AM, Luis R. Rodriguez wrote: > >There is already a check for apm_info.bios == 0, the > >apm_info.bios is set from the boot_params.apm_bios_info. > >Both Xen and lguest, which are also the only ones that

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Luis R. Rodriguez
On Fri, Feb 19, 2016 at 10:08:43AM -0500, Boris Ostrovsky wrote: > > > On 02/19/2016 08:08 AM, Luis R. Rodriguez wrote: > >There is already a check for apm_info.bios == 0, the > >apm_info.bios is set from the boot_params.apm_bios_info. > >Both Xen and lguest, which are also the only ones that

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Boris Ostrovsky
On 02/19/2016 08:08 AM, Luis R. Rodriguez wrote: There is already a check for apm_info.bios == 0, the apm_info.bios is set from the boot_params.apm_bios_info. Both Xen and lguest, which are also the only ones that set paravirt_enabled to true) do never set the apm_bios_info, the

Re: [PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Boris Ostrovsky
On 02/19/2016 08:08 AM, Luis R. Rodriguez wrote: There is already a check for apm_info.bios == 0, the apm_info.bios is set from the boot_params.apm_bios_info. Both Xen and lguest, which are also the only ones that set paravirt_enabled to true) do never set the apm_bios_info, the

[PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Luis R. Rodriguez
There is already a check for apm_info.bios == 0, the apm_info.bios is set from the boot_params.apm_bios_info. Both Xen and lguest, which are also the only ones that set paravirt_enabled to true) do never set the apm_bios_info, the paravirt_enabled() check is simply not needed. Signed-off-by: Luis

[PATCH 5/9] apm32: remove paravirt_enabled() use

2016-02-19 Thread Luis R. Rodriguez
There is already a check for apm_info.bios == 0, the apm_info.bios is set from the boot_params.apm_bios_info. Both Xen and lguest, which are also the only ones that set paravirt_enabled to true) do never set the apm_bios_info, the paravirt_enabled() check is simply not needed. Signed-off-by: Luis