Re: [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-04-19 Thread Paul Kocialkowski
Hi and thanks for the review, On Fri, 2018-03-09 at 14:57 +0100, Maxime Ripard wrote: > On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote: > > +/* > > + * mem2mem callbacks > > + */ > > + > > +void job_abort(void *priv) > > +{} > > Is that still needed? v2 contains a proper imple

Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-04-19 Thread Paul Kocialkowski
Hi, On Mon, 2018-03-12 at 20:29 +, Joonas Kylmälä wrote: > Paul Kocialkowski: > > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > > new file mode 100644 > > index ..88624035e0e3 > > --- /dev/null > > +++ b/d

Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-04-19 Thread Paul Kocialkowski
Hi, On Mon, 2018-03-12 at 17:15 +, Joonas Kylmälä wrote: > Paul Kocialkowski: > > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus_regs.h > > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus_regs.h > > new file mode 100644 > > index ..7384daa94737 > > --- /dev/null

Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-03-12 Thread Joonas Kylmälä
Paul Kocialkowski: > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > new file mode 100644 > index ..88624035e0e3 > --- /dev/null > +++ b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > @@ -0,0 +1,313 @@ > +/*

Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-03-12 Thread Joonas Kylmälä
Paul Kocialkowski: > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus_regs.h > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus_regs.h > new file mode 100644 > index ..7384daa94737 > --- /dev/null > +++ b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus_regs.h > @@ -0,0

Re: [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-03-09 Thread Paul Kocialkowski
Hi, On Fri, 2018-03-09 at 14:57 +0100, Maxime Ripard wrote: > Hi, > > On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote: > > +/* > > + * mem2mem callbacks > > + */ > > + > > +void job_abort(void *priv) > > +{} > > Is that still needed? It looks like we need a dummy callback here

Re: [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-03-09 Thread Maxime Ripard
Hi, On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote: > +/* > + * mem2mem callbacks > + */ > + > +void job_abort(void *priv) > +{} Is that still needed? > +/* > + * device_run() - prepares and starts processing > + */ > +void device_run(void *priv) > +{ This function (and the o

[PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-03-09 Thread Paul Kocialkowski
From: Florent Revest This patch adds a "sunxi-cedrus" v4l2 m2m decoder driver for Allwinner's Video Processing Unit. This VPU has a low-level interface which requires manual registers writing for frame headers. Hence, it depends on the Request API to synchronize buffers with controls. Most of th