Re: [PATCH 5/9] mm/rmap: extend rmap_walk_xxx() to cope with different cases

2013-12-02 Thread Joonsoo Kim
On Mon, Dec 02, 2013 at 03:09:42PM -0500, Naoya Horiguchi wrote: > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > > index 0f65686..58624b4 100644 > > --- a/include/linux/rmap.h > > +++ b/include/linux/rmap.h > > @@ -239,6 +239,12 @@ struct rmap_walk_control { > > int (*main)(struc

Re: [PATCH 5/9] mm/rmap: extend rmap_walk_xxx() to cope with different cases

2013-12-02 Thread Naoya Horiguchi
On Thu, Nov 28, 2013 at 04:48:42PM +0900, Joonsoo Kim wrote: > There are a lot of common parts in traversing functions, but there are > also a little of uncommon parts in it. By assigning proper function > pointer on each rmap_walker_control, we can handle these difference > correctly. > > Followi

[PATCH 5/9] mm/rmap: extend rmap_walk_xxx() to cope with different cases

2013-11-27 Thread Joonsoo Kim
There are a lot of common parts in traversing functions, but there are also a little of uncommon parts in it. By assigning proper function pointer on each rmap_walker_control, we can handle these difference correctly. Following are differences we should handle. 1. difference of lock function in a