Robert,
On Thu, Feb 12, 2015 at 05:26:20PM +0100, Robert Jarzmik wrote:
> Antoine Tenart writes:
>
> >> All these ifs per variant will add complexity to the current driver, won't
> >> they
> >> ?
> >
> > Given the current state of this driver I believe this would be a better
> > idea to first r
Antoine Tenart writes:
>> All these ifs per variant will add complexity to the current driver, won't
>> they
>> ?
>
> Given the current state of this driver I believe this would be a better
> idea to first rework it to use the nand framework properly. Then it will
> be possible to have a look on
Robert,
On Tue, Feb 10, 2015 at 08:50:41PM +0100, Robert Jarzmik wrote:
> Boris Brezillon writes:
> > On Tue, 27 Jan 2015 15:10:12 +0100
> > Antoine Tenart wrote:
> >
> >> The nand controller on Marvell Berlin SoC reuse the pxa3xx nand driver
> >> as it quite close. The process of sending comman
Boris,
On Mon, Feb 09, 2015 at 12:55:03AM +0100, Boris Brezillon wrote:
> On Tue, 27 Jan 2015 15:10:12 +0100
> Antoine Tenart wrote:
>
> >
> > + if (info->variant == PXA3XX_NAND_VARIANT_BERLIN2 &&
> > + info->ndcb0 & NDCB0_LEN_OVRD)
> > + n
Hi Boris,
On Sun, Feb 08, 2015 at 10:06:33PM +0100, Boris Brezillon wrote:
> On Tue, 27 Jan 2015 15:10:12 +0100
> Antoine Tenart wrote:
> > +
> > +#define BERLIN_NAND_CMD_RNDOUT 0x3000
>
> Your specific RNDOUT command looks like a regular READ0 (0x0) +
> READSTART (0x30) sequence, I
Boris Brezillon writes:
> On Tue, 27 Jan 2015 15:10:12 +0100
> Antoine Tenart wrote:
>
>> The nand controller on Marvell Berlin SoC reuse the pxa3xx nand driver
>> as it quite close. The process of sending commands can be compared to
>> the one of the Marvell armada 370: read and write commands
On Tue, 27 Jan 2015 15:10:12 +0100
Antoine Tenart wrote:
> The nand controller on Marvell Berlin SoC reuse the pxa3xx nand driver
> as it quite close. The process of sending commands can be compared to
> the one of the Marvell armada 370: read and write commands are done in
> chunks.
>
> But the
Hi Antoine,
I didn't review the whole patch yet, but I'll come back to this review
soon.
On Tue, 27 Jan 2015 15:10:12 +0100
Antoine Tenart wrote:
> The nand controller on Marvell Berlin SoC reuse the pxa3xx nand driver
> as it quite close. The process of sending commands can be compared to
> th
On Tue, Jan 27, 2015 at 11:42:08AM -0300, Ezequiel Garcia wrote:
> On 01/27/2015 11:10 AM, Antoine Tenart wrote:
> > --- a/drivers/mtd/nand/pxa3xx_nand.c
> > +++ b/drivers/mtd/nand/pxa3xx_nand.c
...
> > @@ -244,10 +254,13 @@ module_param(use_dma, bool, 0444);
> > MODULE_PARM_DESC(use_dma, "enable
On 01/27/2015 11:10 AM, Antoine Tenart wrote:
> The nand controller on Marvell Berlin SoC reuse the pxa3xx nand driver
> as it quite close. The process of sending commands can be compared to
> the one of the Marvell armada 370: read and write commands are done in
> chunks.
>
> But the Berlin nand
The nand controller on Marvell Berlin SoC reuse the pxa3xx nand driver
as it quite close. The process of sending commands can be compared to
the one of the Marvell armada 370: read and write commands are done in
chunks.
But the Berlin nand controller has some other specificities which
require some
11 matches
Mail list logo
