Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-15 Thread Greg Kroah-Hartman
On Sun, Sep 15, 2019 at 12:34:57PM +0300, Thomas Backlund wrote: > Den 14-09-2019 kl. 11:08, skrev Greg Kroah-Hartman: > > On Sat, Sep 14, 2019 at 09:15:48AM +0200, Stefan Lippers-Hollmann wrote: > > > Hi > > > > > > On 2019-09-14, Greg Kroah-Hartman wrote: > > > > On Sat, Sep 14, 2019 at

Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-15 Thread Thomas Backlund
Den 14-09-2019 kl. 11:08, skrev Greg Kroah-Hartman: On Sat, Sep 14, 2019 at 09:15:48AM +0200, Stefan Lippers-Hollmann wrote: Hi On 2019-09-14, Greg Kroah-Hartman wrote: On Sat, Sep 14, 2019 at 02:54:11AM +0200, Stefan Lippers-Hollmann wrote: On 2019-09-13, Greg Kroah-Hartman wrote: From:

Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-14 Thread Greg Kroah-Hartman
On Sat, Sep 14, 2019 at 09:15:48AM +0200, Stefan Lippers-Hollmann wrote: > Hi > > On 2019-09-14, Greg Kroah-Hartman wrote: > > On Sat, Sep 14, 2019 at 02:54:11AM +0200, Stefan Lippers-Hollmann wrote: > > > On 2019-09-13, Greg Kroah-Hartman wrote: > > > > From: Michael S. Tsirkin > > > > > > > >

Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-14 Thread Stefan Lippers-Hollmann
Hi On 2019-09-14, Greg Kroah-Hartman wrote: > On Sat, Sep 14, 2019 at 02:54:11AM +0200, Stefan Lippers-Hollmann wrote: > > On 2019-09-13, Greg Kroah-Hartman wrote: > > > From: Michael S. Tsirkin > > > > > > commit a89db445fbd7f1f8457b03759aa7343fa530ef6b upstream. > > > > > > iovec addresses

Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-13 Thread Greg Kroah-Hartman
On Sat, Sep 14, 2019 at 02:54:11AM +0200, Stefan Lippers-Hollmann wrote: > Hi > > On 2019-09-13, Greg Kroah-Hartman wrote: > > From: Michael S. Tsirkin > > > > commit a89db445fbd7f1f8457b03759aa7343fa530ef6b upstream. > > > > iovec addresses coming from vhost are assumed to be > > pre-validated,

Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-13 Thread Stefan Lippers-Hollmann
Hi On 2019-09-13, Greg Kroah-Hartman wrote: > From: Michael S. Tsirkin > > commit a89db445fbd7f1f8457b03759aa7343fa530ef6b upstream. > > iovec addresses coming from vhost are assumed to be > pre-validated, but in fact can be speculated to a value > out of range. > > Userspace address are later

[PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-13 Thread Greg Kroah-Hartman
From: Michael S. Tsirkin commit a89db445fbd7f1f8457b03759aa7343fa530ef6b upstream. iovec addresses coming from vhost are assumed to be pre-validated, but in fact can be speculated to a value out of range. Userspace address are later validated with array_index_nospec so we can be sure kernel