On Sat, Oct 05, 2019 at 12:55:51PM +0200, Hans de Goede wrote:
> Commit c394159310d0 ("Input: soc_button_array - add support for newer
> surface devices") not only added support for the MSHW0040 ACPI HID,
> but for some reason it also makes changes to the error handling of the
>
Hi,
On 05-10-2019 17:01, Maximilian Luz wrote:
Hi, again
On 10/5/19 3:20 PM, Hans de Goede wrote:
Ok, on x86 the GPIO drivers really should all be builtin because
various ACPI methods including device D0 / D3 (power-on/off) methods
may depend on them. So normally this should never happen.
If
Hi, again
On 10/5/19 3:20 PM, Hans de Goede wrote:
Ok, on x86 the GPIO drivers really should all be builtin because
various ACPI methods including device D0 / D3 (power-on/off) methods
may depend on them. So normally this should never happen.
If this (-EPROBE_DEFER on surface devices) somehow
Hi,
On 10/5/19 3:20 PM, Hans de Goede wrote:
Hi,
S-o-b is only for patches which pass through your hands, e.g. if
you make changes to my patch and submit a v2 of it.
I guess you mean / want one of:
Acked-by: ...
or
Reviewed-by: ...
?
I apologize if the s-o-b was misplaced here, it was
Hi,
On 05-10-2019 14:17, Maximilian Luz wrote:
Hi,
sorry for the inconvenience this change has caused.
On 10/5/19 12:55 PM, Hans de Goede wrote:
Note ideally this seamingly unrelated change would have been made in a
separate commit, with a message explaining the what and why of this
change.
On Sat, Oct 05, 2019 at 12:55:51PM +0200, Hans de Goede wrote:
> Commit c394159310d0 ("Input: soc_button_array - add support for newer
> surface devices") not only added support for the MSHW0040 ACPI HID,
> but for some reason it also makes changes to the error handling of the
>
Hi,
sorry for the inconvenience this change has caused.
On 10/5/19 12:55 PM, Hans de Goede wrote:
Note ideally this seamingly unrelated change would have been made in a
separate commit, with a message explaining the what and why of this
change.
Would I have known the impact, then yes. This
Commit c394159310d0 ("Input: soc_button_array - add support for newer
surface devices") not only added support for the MSHW0040 ACPI HID,
but for some reason it also makes changes to the error handling of the
soc_button_lookup_gpio() call in soc_button_device_create(). Note ideally
this seamingly
8 matches
Mail list logo
