From: Alexander Potapenko <gli...@google.com> [ Upstream commit 1d605416fb7175e1adf094251466caa52093b413 ]
KMSAN reported uninitialized data being written to disk when dumping core. As a result, several kilobytes of kmalloc memory may be written to the core file and then read by a non-privileged user. Reported-by: sam <sunha...@outlook.com> Signed-off-by: Alexander Potapenko <gli...@google.com> Signed-off-by: Andrew Morton <a...@linux-foundation.org> Acked-by: Kees Cook <keesc...@chromium.org> Cc: Al Viro <v...@zeniv.linux.org.uk> Cc: Alexey Dobriyan <adobri...@gmail.com> Cc: <sta...@vger.kernel.org> Link: http://lkml.kernel.org/r/20200419100848.63472-1-gli...@google.com Link: https://github.com/google/kmsan/issues/76 Signed-off-by: Linus Torvalds <torva...@linux-foundation.org> Signed-off-by: Sasha Levin <sas...@kernel.org> --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index f4713ea76e82..54f888ddb8cc 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1733,7 +1733,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t, (!regset->active || regset->active(t->task, regset) > 0)) { int ret; size_t size = regset_size(t->task, regset); - void *data = kmalloc(size, GFP_KERNEL); + void *data = kzalloc(size, GFP_KERNEL); if (unlikely(!data)) return 0; ret = regset->get(t->task, regset, -- 2.25.1
