Re: [PATCH 6/12] random pt4: Replace SHA with faster version

2005-01-25 Thread Denis Vlasenko
On Tuesday 25 January 2005 23:14, Matt Mackall wrote: > On Tue, Jan 25, 2005 at 11:07:21PM +0200, Denis Vlasenko wrote: > > On Friday 21 January 2005 23:41, Matt Mackall wrote: > > > - * @W: 80 words of workspace > > > + * @W: 80 words of workspace, caller should clear > > > > Why? > >

Re: [PATCH 6/12] random pt4: Replace SHA with faster version

2005-01-25 Thread Denis Vlasenko
On Friday 21 January 2005 23:41, Matt Mackall wrote: > - * @W: 80 words of workspace > + * @W: 80 words of workspace, caller should clear Why? > * > * This function generates a SHA1 digest for a single. Be warned, it > * does not handle padding and message digest, do not confuse i

Re: [PATCH 6/12] random pt4: Replace SHA with faster version

2005-01-25 Thread Matt Mackall
On Tue, Jan 25, 2005 at 11:07:21PM +0200, Denis Vlasenko wrote: > On Friday 21 January 2005 23:41, Matt Mackall wrote: > > - * @W: 80 words of workspace > > + * @W: 80 words of workspace, caller should clear > > Why? Are you asking why should the caller clear or why should it be cleared

[PATCH 6/12] random pt4: Replace SHA with faster version

2005-01-21 Thread Matt Mackall
A replacement SHA routine that's slightly larger, but over twice as fast. It's also faster and much smaller than the cryptolib version. size speedbuffer size original:350B 2.3us 320B cryptolib: 5776B 1.2us 80B this code: 466B 1.0us 320B alte