Re: [PATCH 6/4] [-mm patch] use the existing offsetof().

2007-09-25 Thread Ken'ichi Ohmichi
Hi Satyam, Satyam Sharma wrote: > > BTW I don't think these macros are such a big win in readability or > > code clarity anyway. And I noticed that there are still some open > > calls to vmcoreinfo_append_str() in kexec.c (such as for the OS_RELEASE > > case) which you haven't macro-ized ... we e

Re: [PATCH 6/4] [-mm patch] use the existing offsetof().

2007-09-20 Thread Satyam Sharma
On Thu, 20 Sep 2007, Ken'ichi Ohmichi wrote: > > [PATCH 6/4] [-mm patch] use the existing offsetof(). > It is better that offsetof() is used for VMCOREINFO_OFFSET(). > This idea is Joe Perches's. > > > > Thanks > Ken'ichi Ohmichi > > --

[PATCH 6/4] [-mm patch] use the existing offsetof().

2007-09-19 Thread Ken'ichi Ohmichi
[PATCH 6/4] [-mm patch] use the existing offsetof(). It is better that offsetof() is used for VMCOREINFO_OFFSET(). This idea is Joe Perches's. Thanks Ken'ichi Ohmichi --- Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Ken'ichi Ohmichi <[EMAIL PROT