Re: [PATCH 6/5] timers: enable irqs in __mod_timer()

2005-03-21 Thread Andrew Morton
Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > If the timer is currently running on another CPU, __mod_timer() > spins with interrupts disabled and timer->lock held. I think it > is better to spin_unlock_irqrestore(&timer->lock) in __mod_timer's > retry path. > > This patch is unneccessary long.

[PATCH 6/5] timers: enable irqs in __mod_timer()

2005-03-21 Thread Oleg Nesterov
On top of "[PATCH 5/5] timers: cleanup, kill __get_base()", see http://marc.theaimsgroup.com/?l=linux-kernel&m=25359121372 If the timer is currently running on another CPU, __mod_timer() spins with interrupts disabled and timer->lock held. I think it is better to spin_unlock_irqrestore(&timer-