Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-05 Thread Andy Lutomirski
> + err_str_append(error_code, err_txt, X86_PF_INSTR, "[INSTR]", NULL); > + err_str_append(error_code, err_txt, X86_PF_PK,"[PK]" , NULL); > + err_str_append(error_code, err_txt, X86_PF_WRITE | X86_PF_INSTR, NULL, > +

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-05 Thread Andy Lutomirski
> + err_str_append(error_code, err_txt, X86_PF_INSTR, "[INSTR]", NULL); > + err_str_append(error_code, err_txt, X86_PF_PK,"[PK]" , NULL); > + err_str_append(error_code, err_txt, X86_PF_WRITE | X86_PF_INSTR, NULL, > +

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-05 Thread Sean Christopherson
On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > wrote: > > arch/x86/mm/fault.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > > index

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-05 Thread Sean Christopherson
On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > wrote: > > arch/x86/mm/fault.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > > index

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Andy Lutomirski
On Tue, Dec 4, 2018 at 11:52 AM Sean Christopherson wrote: > > On Tue, Dec 04, 2018 at 11:47:10AM -0800, Andy Lutomirski wrote: > > On Tue, Dec 4, 2018 at 11:34 AM Sean Christopherson > > wrote: > > > > > > On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > > > > On Tue, Nov 27,

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Andy Lutomirski
On Tue, Dec 4, 2018 at 11:52 AM Sean Christopherson wrote: > > On Tue, Dec 04, 2018 at 11:47:10AM -0800, Andy Lutomirski wrote: > > On Tue, Dec 4, 2018 at 11:34 AM Sean Christopherson > > wrote: > > > > > > On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > > > > On Tue, Nov 27,

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Sean Christopherson
On Tue, Dec 04, 2018 at 11:47:10AM -0800, Andy Lutomirski wrote: > On Tue, Dec 4, 2018 at 11:34 AM Sean Christopherson > wrote: > > > > On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > > > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > > > wrote: > > > > diff --git

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Sean Christopherson
On Tue, Dec 04, 2018 at 11:47:10AM -0800, Andy Lutomirski wrote: > On Tue, Dec 4, 2018 at 11:34 AM Sean Christopherson > wrote: > > > > On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > > > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > > > wrote: > > > > diff --git

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Andy Lutomirski
On Tue, Dec 4, 2018 at 11:34 AM Sean Christopherson wrote: > > On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > > wrote: > > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > > > index 2ff25ad33233..510e263c256b

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Andy Lutomirski
On Tue, Dec 4, 2018 at 11:34 AM Sean Christopherson wrote: > > On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > > wrote: > > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > > > index 2ff25ad33233..510e263c256b

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Sean Christopherson
On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > wrote: > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > > index 2ff25ad33233..510e263c256b 100644 > > --- a/arch/x86/mm/fault.c > > +++ b/arch/x86/mm/fault.c > > @@

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Sean Christopherson
On Tue, Dec 04, 2018 at 11:22:25AM -0800, Andy Lutomirski wrote: > On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson > wrote: > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > > index 2ff25ad33233..510e263c256b 100644 > > --- a/arch/x86/mm/fault.c > > +++ b/arch/x86/mm/fault.c > > @@

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Andy Lutomirski
On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson wrote: > > On Thu, Nov 22, 2018 at 09:41:19AM +0100, Ingo Molnar wrote: > > > > * Andy Lutomirski wrote: > > > > > One of Linus' favorite hobbies seems to be looking at OOPSes and > > > decoding the error code in his head. This is not one of

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-12-04 Thread Andy Lutomirski
On Tue, Nov 27, 2018 at 7:32 AM Sean Christopherson wrote: > > On Thu, Nov 22, 2018 at 09:41:19AM +0100, Ingo Molnar wrote: > > > > * Andy Lutomirski wrote: > > > > > One of Linus' favorite hobbies seems to be looking at OOPSes and > > > decoding the error code in his head. This is not one of

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-11-27 Thread Sean Christopherson
On Thu, Nov 22, 2018 at 09:41:19AM +0100, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > > > One of Linus' favorite hobbies seems to be looking at OOPSes and > > decoding the error code in his head. This is not one of my favorite > > hobbies :) > > > > Teach the page fault OOPS hander to

Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-11-27 Thread Sean Christopherson
On Thu, Nov 22, 2018 at 09:41:19AM +0100, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > > > One of Linus' favorite hobbies seems to be looking at OOPSes and > > decoding the error code in his head. This is not one of my favorite > > hobbies :) > > > > Teach the page fault OOPS hander to

[PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-11-22 Thread Ingo Molnar
* Andy Lutomirski wrote: > One of Linus' favorite hobbies seems to be looking at OOPSes and > decoding the error code in his head. This is not one of my favorite > hobbies :) > > Teach the page fault OOPS hander to decode the error code. If it's > a !USER fault from user mode, print an

[PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

2018-11-22 Thread Ingo Molnar
* Andy Lutomirski wrote: > One of Linus' favorite hobbies seems to be looking at OOPSes and > decoding the error code in his head. This is not one of my favorite > hobbies :) > > Teach the page fault OOPS hander to decode the error code. If it's > a !USER fault from user mode, print an