Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

2007-08-24 Thread Blaisorblade
On venerdì 24 agosto 2007, Jeff Dike wrote: > On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote: > > > actually. Personally I'd prefer: > > > > > > else > > > type = OS_TYPE_DIR; > > > > I strongly agree with this style; beyond style itself, one strong reason > > is that join

Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

2007-08-24 Thread Jeff Dike
On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote: > > actually. Personally I'd prefer: > > > > else > > type = OS_TYPE_DIR; > > I strongly agree with this style; beyond style itself, one strong reason is > that joining statements hinder singlestepping through function

Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

2007-08-23 Thread Blaisorblade
On sabato 18 agosto 2007, Satyam Sharma wrote: > On Fri, 17 Aug 2007, Jeff Dike wrote: > > Style fixes in hostfs. > > @@ -328,17 +326,17 @@ int hostfs_readdir(struct file *file, vo > > [...] > > - if(error) break; > > + if (error) break; > > if (error) >

Re: [PATCH 6/6] UML - Fix hostfs style

2007-08-18 Thread Satyam Sharma
On Fri, 17 Aug 2007, Jeff Dike wrote: > Style fixes in hostfs. > Index: linux-2.6.22/fs/hostfs/hostfs_kern.c > [...] > @@ -6,22 +6,15 @@ > * 2003-02-10 Petr Baudis <[EMAIL PROTECTED]> > */ > > -#include > #include > #include > -#include > -#include > +#include > #include > -#inc

[PATCH 6/6] UML - Fix hostfs style

2007-08-17 Thread Jeff Dike
Style fixes in hostfs. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- fs/hostfs/hostfs.h |9 + fs/hostfs/hostfs_kern.c | 226 fs/hostfs/hostfs_user.c | 139 + 3 files changed, 202 insertions(+), 172 deletions