Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Viresh Kumar
On 16 October 2014 23:33, Aaro Koskinen wrote: > Why it's called "ls1x-cpufreq" instead of "loongson1_cpufreq"? This is what Kelvin told me when I asked him the same query: Other drivers of loongson1 are already named *ls1x*, such as clk-ls1x.c and rtc-ls1x.c. So I just keep pace with them. --

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Aaro Koskinen
Hi, On Wed, Oct 15, 2014 at 03:23:32PM +0800, Kelvin Cheung wrote: > This patch adds cpufreq driver for Loongson1B which > is capable of changing the CPU frequency dynamically. > > Signed-off-by: Kelvin Cheung [...] > obj-$(CONFIG_LOONGSON2_CPUFREQ) += loongson2_cpufreq.o >

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Viresh Kumar
On 16 October 2014 15:00, Kelvin Cheung wrote: Just to let u know, your mails are probably generated in html whereas they should be in text mode. > 2014-10-16 16:23 GMT+08:00 Viresh Kumar : >> >> This is not how we send updated versions, GIT and other tools will commit >> the "(UPDATED)" part

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Viresh Kumar
This is not how we send updated versions, GIT and other tools will commit the "(UPDATED)" part while applying. What you were required to do was something like: git format-patch A..B --subject-prefix="PATCH V2" On 15 October 2014 12:53, Kelvin Cheung wrote: > +static int

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Viresh Kumar
This is not how we send updated versions, GIT and other tools will commit the (UPDATED) part while applying. What you were required to do was something like: git format-patch A..B --subject-prefix=PATCH V2 On 15 October 2014 12:53, Kelvin Cheung keguang.zh...@gmail.com wrote: +static int

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Viresh Kumar
On 16 October 2014 15:00, Kelvin Cheung keguang.zh...@gmail.com wrote: Just to let u know, your mails are probably generated in html whereas they should be in text mode. 2014-10-16 16:23 GMT+08:00 Viresh Kumar viresh.ku...@linaro.org: This is not how we send updated versions, GIT and other

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Aaro Koskinen
Hi, On Wed, Oct 15, 2014 at 03:23:32PM +0800, Kelvin Cheung wrote: This patch adds cpufreq driver for Loongson1B which is capable of changing the CPU frequency dynamically. Signed-off-by: Kelvin Cheung keguang.zh...@gmail.com [...] obj-$(CONFIG_LOONGSON2_CPUFREQ) +=

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-16 Thread Viresh Kumar
On 16 October 2014 23:33, Aaro Koskinen aaro.koski...@iki.fi wrote: Why it's called ls1x-cpufreq instead of loongson1_cpufreq? This is what Kelvin told me when I asked him the same query: Other drivers of loongson1 are already named *ls1x*, such as clk-ls1x.c and rtc-ls1x.c. So I just keep pace

[PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-15 Thread Kelvin Cheung
This patch adds cpufreq driver for Loongson1B which is capable of changing the CPU frequency dynamically. Signed-off-by: Kelvin Cheung --- drivers/cpufreq/Kconfig| 10 ++ drivers/cpufreq/Makefile | 1 + drivers/cpufreq/ls1x-cpufreq.c | 233

[PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B (UPDATED)

2014-10-15 Thread Kelvin Cheung
This patch adds cpufreq driver for Loongson1B which is capable of changing the CPU frequency dynamically. Signed-off-by: Kelvin Cheung keguang.zh...@gmail.com --- drivers/cpufreq/Kconfig| 10 ++ drivers/cpufreq/Makefile | 1 + drivers/cpufreq/ls1x-cpufreq.c | 233

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B

2014-10-14 Thread Viresh Kumar
On 14 October 2014 12:29, Kelvin Cheung wrote: > > 2014-10-10 12:40 GMT+08:00 Viresh Kumar : >> > +#include >> > +#include >> >> Okay, it looks like I have forgotten some of the C basics :) >> But wouldn't the above two lines search for this file in , unless >> you have compiled it with

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B

2014-10-14 Thread Viresh Kumar
On 14 October 2014 12:29, Kelvin Cheung keguang.zh...@gmail.com wrote: 2014-10-10 12:40 GMT+08:00 Viresh Kumar viresh.ku...@linaro.org: +#include cpufreq.h +#include loongson1.h Okay, it looks like I have forgotten some of the C basics :) But wouldn't the above two lines search for this

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B

2014-10-09 Thread Viresh Kumar
On 10 October 2014 09:13, Kelvin Cheung wrote: Why should we apply this patch and what is it all about ? That's what this field is used for, please don't leave it empty. > Signed-off-by: Kelvin Cheung > --- > drivers/cpufreq/Kconfig| 10 ++ > drivers/cpufreq/Makefile | 1 + >

[PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B

2014-10-09 Thread Kelvin Cheung
Signed-off-by: Kelvin Cheung --- drivers/cpufreq/Kconfig| 10 ++ drivers/cpufreq/Makefile | 1 + drivers/cpufreq/ls1x-cpufreq.c | 217 + 3 files changed, 228 insertions(+) create mode 100644 drivers/cpufreq/ls1x-cpufreq.c diff --git

[PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B

2014-10-09 Thread Kelvin Cheung
Signed-off-by: Kelvin Cheung keguang.zh...@gmail.com --- drivers/cpufreq/Kconfig| 10 ++ drivers/cpufreq/Makefile | 1 + drivers/cpufreq/ls1x-cpufreq.c | 217 + 3 files changed, 228 insertions(+) create mode 100644

Re: [PATCH 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B

2014-10-09 Thread Viresh Kumar
On 10 October 2014 09:13, Kelvin Cheung keguang.zh...@gmail.com wrote: Why should we apply this patch and what is it all about ? That's what this field is used for, please don't leave it empty. Signed-off-by: Kelvin Cheung keguang.zh...@gmail.com --- drivers/cpufreq/Kconfig| 10 ++