Re: [PATCH 6/6] cpuset dirty limits

2007-09-18 Thread Ethan Solomita
Christoph Lameter wrote: > On Fri, 14 Sep 2007, Andrew Morton wrote: > >>> + mutex_lock(&callback_mutex); >>> + *cs_int = val; >>> + mutex_unlock(&callback_mutex); >> I don't think this locking does anything? > > Locking is wrong here. The lock needs to be taken before the cs pointer > is

Re: [PATCH 6/6] cpuset dirty limits

2007-09-17 Thread Christoph Lameter
On Fri, 14 Sep 2007, Andrew Morton wrote: > > + mutex_lock(&callback_mutex); > > + *cs_int = val; > > + mutex_unlock(&callback_mutex); > > I don't think this locking does anything? Locking is wrong here. The lock needs to be taken before the cs pointer is dereferenced from the caller. >

Re: [PATCH 6/6] cpuset dirty limits

2007-09-14 Thread Andrew Morton
On Tue, 11 Sep 2007 18:42:16 -0700 Ethan Solomita <[EMAIL PROTECTED]> wrote: > Per cpuset dirty ratios > > This implements dirty ratios per cpuset. Two new files are added > to the cpuset directories: > > background_dirty_ratioPercentage at which background writeback starts > > throttle

[PATCH 6/6] cpuset dirty limits

2007-09-11 Thread Ethan Solomita
Per cpuset dirty ratios This implements dirty ratios per cpuset. Two new files are added to the cpuset directories: background_dirty_ratio Percentage at which background writeback starts throttle_dirty_ratioPercentage at which the application is throttled and we star

[PATCH 6/6] cpuset dirty limits

2007-07-17 Thread Ethan Solomita
Per cpuset dirty ratios This implements dirty ratios per cpuset. Two new files are added to the cpuset directories: background_dirty_ratio Percentage at which background writeback starts throttle_dirty_ratioPercentage at which the application is throttled and we star