Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

On Wed, Jun 17, 2020 at 11:51:07PM -0700, Christoph Hellwig wrote: > Much better. Although if we touch all the callers we might as well > pass the csd as the argument to the callback, as with that we can > pretty trivially remove the private data field later. My plan was to introduce a new

Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

On Wed, Jun 17, 2020 at 01:04:01PM +0200, Peter Zijlstra wrote: > On Wed, Jun 17, 2020 at 01:23:49AM -0700, Christoph Hellwig wrote: > > > > @@ -178,9 +178,7 @@ static void zpci_handle_fallback_irq(voi > > > if (atomic_inc_return(_data->scheduled) > 1) > > > continue;

Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

On Wed, Jun 17, 2020 at 01:23:49AM -0700, Christoph Hellwig wrote: > > @@ -178,9 +178,7 @@ static void zpci_handle_fallback_irq(voi > > if (atomic_inc_return(_data->scheduled) > 1) > > continue; > > > > - cpu_data->csd.func = zpci_handle_remote_irq; > >

Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

On Wed, Jun 17, 2020 at 01:23:49AM -0700, Christoph Hellwig wrote: > > -static DEFINE_PER_CPU(call_single_data_t, backtrace_csd); > > +static DEFINE_PER_CPU(call_single_data_t, backtrace_csd) = > > CSD_INIT(handle_backtrace, NULL); > > static struct cpumask backtrace_csd_busy; > > Besides the

Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

> -static DEFINE_PER_CPU(call_single_data_t, backtrace_csd); > +static DEFINE_PER_CPU(call_single_data_t, backtrace_csd) = > CSD_INIT(handle_backtrace, NULL); > static struct cpumask backtrace_csd_busy; Besides the crazy long line: does assigning to a DEFINE_PER_CPU really work and initialize

Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

On Mon, Jun 15, 2020 at 02:57:00PM +0200, Peter Zijlstra wrote: > Get rid of the __call_single_node union and cleanup the API a little > to avoid external code relying on the structure layout as much. > > Signed-off-by: Peter Zijlstra (Intel) For kgdb, Acked-by: Daniel Thompson Daniel. >

Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

On 6/15/20 6:57 AM, Peter Zijlstra wrote: > Get rid of the __call_single_node union and cleanup the API a little > to avoid external code relying on the structure layout as much. core and block bits look good to me. -- Jens Axboe

[PATCH 6/6] smp: Cleanup smp_call_function*()

Get rid of the __call_single_node union and cleanup the API a little to avoid external code relying on the structure layout as much. Signed-off-by: Peter Zijlstra (Intel) --- arch/mips/kernel/process.c |3 - arch/mips/kernel/smp.c | 24