Re: [PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-09-09 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Thu, Sep 08, 2016 at 09:04:01AM +0200, Ingo Molnar wrote: > > > > * Josh Poimboeuf wrote: > > > > > arch/x86/kernel/dumpstack_32.c | 14 ++ > > > > > --- a/arch/x86/kernel/dumpstack_32.c > > > +++

Re: [PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-09-09 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Thu, Sep 08, 2016 at 09:04:01AM +0200, Ingo Molnar wrote: > > > > * Josh Poimboeuf wrote: > > > > > arch/x86/kernel/dumpstack_32.c | 14 ++ > > > > > --- a/arch/x86/kernel/dumpstack_32.c > > > +++ b/arch/x86/kernel/dumpstack_32.c > > > > > +static

Re: [PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-09-08 Thread Josh Poimboeuf
On Thu, Sep 08, 2016 at 09:04:01AM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > arch/x86/kernel/dumpstack_32.c | 14 ++ > > > --- a/arch/x86/kernel/dumpstack_32.c > > +++ b/arch/x86/kernel/dumpstack_32.c > > > +static void

Re: [PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-09-08 Thread Josh Poimboeuf
On Thu, Sep 08, 2016 at 09:04:01AM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > arch/x86/kernel/dumpstack_32.c | 14 ++ > > > --- a/arch/x86/kernel/dumpstack_32.c > > +++ b/arch/x86/kernel/dumpstack_32.c > > > +static void *is_softirq_stack(unsigned long *stack); >

Re: [PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-09-08 Thread Ingo Molnar
* Josh Poimboeuf wrote: > arch/x86/kernel/dumpstack_32.c | 14 ++ > --- a/arch/x86/kernel/dumpstack_32.c > +++ b/arch/x86/kernel/dumpstack_32.c > +static void *is_softirq_stack(unsigned long *stack); > { FYI, this bit clearly wasn't build tested on 32-bit

Re: [PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-09-08 Thread Ingo Molnar
* Josh Poimboeuf wrote: > arch/x86/kernel/dumpstack_32.c | 14 ++ > --- a/arch/x86/kernel/dumpstack_32.c > +++ b/arch/x86/kernel/dumpstack_32.c > +static void *is_softirq_stack(unsigned long *stack); > { FYI, this bit clearly wasn't build tested on 32-bit even once - I'm

[PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-08-24 Thread Josh Poimboeuf
show_stack_log_lvl() and dump_trace() are already preemption safe: - If they're running in irq or exception context, preemption is already disabled and the percpu stack pointers can be trusted. - If they're running with preemption enabled, they must be running on the task stack anyway, so it

[PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

2016-08-24 Thread Josh Poimboeuf
show_stack_log_lvl() and dump_trace() are already preemption safe: - If they're running in irq or exception context, preemption is already disabled and the percpu stack pointers can be trusted. - If they're running with preemption enabled, they must be running on the task stack anyway, so it