Re: [PATCH 6/6 linux-next] ubifs: remove else after return

2015-05-22 Thread Richard Weinberger
Am 22.05.2015 um 23:37 schrieb Fabian Frederick: > > >> On 19 May 2015 at 19:57 Richard Weinberger wrote: >> >> >> Am 19.05.2015 um 19:42 schrieb Fabian Frederick: >>> All was compiled but untested. >> >> Can you please test your changes too? >> Trivial looking changes introduce sometim

Re: [PATCH 6/6 linux-next] ubifs: remove else after return

2015-05-22 Thread Fabian Frederick
> On 19 May 2015 at 19:57 Richard Weinberger wrote: > > > Am 19.05.2015 um 19:42 schrieb Fabian Frederick: > >         All was compiled but untested. > > Can you please test your changes too? > Trivial looking changes introduce sometimes issues and having them > tested would be wonderful. > > Yo

Re: [PATCH 6/6 linux-next] ubifs: remove else after return

2015-05-19 Thread Richard Weinberger
Am 19.05.2015 um 19:42 schrieb Fabian Frederick: > All was compiled but untested. Can you please test your changes too? Trivial looking changes introduce sometimes issues and having them tested would be wonderful. You can test UBIFS using nandsim or mtdram on any Linux system. See: http:/

Re: [PATCH 6/6 linux-next] ubifs: remove else after return

2015-05-19 Thread Fabian Frederick
> On 19 May 2015 at 00:17 Richard Weinberger > wrote: > > > On Fri, May 15, 2015 at 11:44 PM, Fabian Frederick wrote: > > simplify code in add_to_lpt_heap() > > > > Signed-off-by: Fabian Frederick > > --- > >  fs/ubifs/lprops.c | 11 +-- > >  1 file changed, 5 insertions(+), 6 deletions

Re: [PATCH 6/6 linux-next] ubifs: remove else after return

2015-05-18 Thread Richard Weinberger
On Fri, May 15, 2015 at 11:44 PM, Fabian Frederick wrote: > simplify code in add_to_lpt_heap() > > Signed-off-by: Fabian Frederick > --- > fs/ubifs/lprops.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c > index a0011aa.

[PATCH 6/6 linux-next] ubifs: remove else after return

2015-05-15 Thread Fabian Frederick
simplify code in add_to_lpt_heap() Signed-off-by: Fabian Frederick --- fs/ubifs/lprops.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c index a0011aa..e1454cf 100644 --- a/fs/ubifs/lprops.c +++ b/fs/ubifs/lprops.c @@ -208,13