Re: [PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint

2020-08-12 Thread Sean Christopherson
On Tue, Jul 21, 2020 at 03:59:06PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Mon, Jul 20, 2020 at 06:52:15PM +0200, Vitaly Kuznetsov wrote: > >> Sean Christopherson writes: > >> > +TRACE_EVENT_KVM_EXIT(kvm_nested_vmexit); > >> > > >> > /* > >> > * Tracepoint for

Re: [PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint

2020-07-21 Thread Steven Rostedt
On Tue, 21 Jul 2020 12:31:30 -0700 Sean Christopherson wrote: > +Steve > > Background: KVM has two tracepoints that effectively trace the same thing > (VM-Exit vs. nested VM-Exit), but use completely different formatting and > nomenclature for each of the existing tracepoints. I want to add a

Re: [PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint

2020-07-21 Thread Sean Christopherson
+Steve Background: KVM has two tracepoints that effectively trace the same thing (VM-Exit vs. nested VM-Exit), but use completely different formatting and nomenclature for each of the existing tracepoints. I want to add a common macro to create the tracepoints so that they capture the exact same

Re: [PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint

2020-07-21 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Mon, Jul 20, 2020 at 06:52:15PM +0200, Vitaly Kuznetsov wrote: >> Sean Christopherson writes: >> > +TRACE_EVENT_KVM_EXIT(kvm_nested_vmexit); >> > >> > /* >> > * Tracepoint for #VMEXIT reinjected to the guest >> > diff --git a/arch/x86/kvm/vmx/nested.c

Re: [PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint

2020-07-20 Thread Sean Christopherson
On Mon, Jul 20, 2020 at 06:52:15PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > +TRACE_EVENT_KVM_EXIT(kvm_nested_vmexit); > > > > /* > > * Tracepoint for #VMEXIT reinjected to the guest > > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c > > index

Re: [PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint

2020-07-20 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Use the newly introduced TRACE_EVENT_KVM_EXIT to define the guts of > kvm_nested_vmexit so that it captures and prints the same information as > with kvm_exit. This has the bonus side effect of fixing the interrupt > info and error code printing for the case where

[PATCH 6/7] KVM: x86: Use common definition for kvm_nested_vmexit tracepoint

2020-07-18 Thread Sean Christopherson
Use the newly introduced TRACE_EVENT_KVM_EXIT to define the guts of kvm_nested_vmexit so that it captures and prints the same information as with kvm_exit. This has the bonus side effect of fixing the interrupt info and error code printing for the case where they're invalid, e.g. if the exit was