Re: [PATCH 6/7] Squashfs: Directly decompress into the page cache for file data

2013-11-23 Thread Phillip Lougher
On 22/11/13 07:40, Roman Peniaev wrote: Hello, Phillip. one remark below: +static int squashfs_read_cache(struct page *target_page, u64 block, int bsize, + int pages, struct page **page) +{ + struct inode *i = target_page->mapping->host; + struct squashfs_cache_entry

Re: [PATCH 6/7] Squashfs: Directly decompress into the page cache for file data

2013-11-23 Thread Phillip Lougher
On 22/11/13 07:40, Roman Peniaev wrote: Hello, Phillip. one remark below: +static int squashfs_read_cache(struct page *target_page, u64 block, int bsize, + int pages, struct page **page) +{ + struct inode *i = target_page-mapping-host; + struct squashfs_cache_entry

Re: [PATCH 6/7] Squashfs: Directly decompress into the page cache for file data

2013-11-21 Thread Roman Peniaev
Hello, Phillip. one remark below: > > +static int squashfs_read_cache(struct page *target_page, u64 block, int bsize, > + int pages, struct page **page) > +{ > + struct inode *i = target_page->mapping->host; > + struct squashfs_cache_entry *buffer = squashfs_get_datablock(i- >i_sb,

Re: [PATCH 6/7] Squashfs: Directly decompress into the page cache for file data

2013-11-21 Thread Roman Peniaev
Hello, Phillip. one remark below: +static int squashfs_read_cache(struct page *target_page, u64 block, int bsize, + int pages, struct page **page) +{ + struct inode *i = target_page-mapping-host; + struct squashfs_cache_entry *buffer = squashfs_get_datablock(i- i_sb, +

[PATCH 6/7] Squashfs: Directly decompress into the page cache for file data

2013-11-19 Thread Phillip Lougher
This introduces an implementation of squashfs_readpage_block() that directly decompresses into the page cache. This uses the previously added page handler abstraction to push down the necessary kmap_atomic/kunmap_atomic operations on the page cache buffers into the decompressors. This enables

[PATCH 6/7] Squashfs: Directly decompress into the page cache for file data

2013-11-19 Thread Phillip Lougher
This introduces an implementation of squashfs_readpage_block() that directly decompresses into the page cache. This uses the previously added page handler abstraction to push down the necessary kmap_atomic/kunmap_atomic operations on the page cache buffers into the decompressors. This enables