Re: [PATCH 6/7] btrfs: Promote to unsigned long long before shifting

2020-10-26 Thread David Sterba
On Mon, Oct 26, 2020 at 04:44:42PM +, Matthew Wilcox wrote: > On Mon, Oct 26, 2020 at 05:35:46PM +0100, David Sterba wrote: > > On Sun, Oct 04, 2020 at 07:04:27PM +0100, Matthew Wilcox (Oracle) wrote: > > > On 32-bit systems, this shift will overflow for files larger than 4GB. > > > > > > Cc:

Re: [PATCH 6/7] btrfs: Promote to unsigned long long before shifting

2020-10-26 Thread Matthew Wilcox
On Mon, Oct 26, 2020 at 05:35:46PM +0100, David Sterba wrote: > On Sun, Oct 04, 2020 at 07:04:27PM +0100, Matthew Wilcox (Oracle) wrote: > > On 32-bit systems, this shift will overflow for files larger than 4GB. > > > > Cc: sta...@vger.kernel.org > > Fixes: 53b381b3abeb ("Btrfs: RAID5 and RAID6")

Re: [PATCH 6/7] btrfs: Promote to unsigned long long before shifting

2020-10-26 Thread David Sterba
On Sun, Oct 04, 2020 at 07:04:27PM +0100, Matthew Wilcox (Oracle) wrote: > On 32-bit systems, this shift will overflow for files larger than 4GB. > > Cc: sta...@vger.kernel.org > Fixes: 53b381b3abeb ("Btrfs: RAID5 and RAID6") > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/btrfs/raid56.c |

Re: [PATCH 6/7] btrfs: Promote to unsigned long long before shifting

2020-10-09 Thread Josef Bacik
On 10/4/20 2:04 PM, Matthew Wilcox (Oracle) wrote: On 32-bit systems, this shift will overflow for files larger than 4GB. Cc: sta...@vger.kernel.org Fixes: 53b381b3abeb ("Btrfs: RAID5 and RAID6") Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Josef Bacik Thanks, Josef

[PATCH 6/7] btrfs: Promote to unsigned long long before shifting

2020-10-04 Thread Matthew Wilcox (Oracle)
On 32-bit systems, this shift will overflow for files larger than 4GB. Cc: sta...@vger.kernel.org Fixes: 53b381b3abeb ("Btrfs: RAID5 and RAID6") Signed-off-by: Matthew Wilcox (Oracle) --- fs/btrfs/raid56.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/raid56.c