Re: [PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-20 Thread kbuild test robot
Hi Keith, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc4 next-20180919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-20 Thread kbuild test robot
Hi Keith, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc4 next-20180919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-20 Thread kbuild test robot
Hi Keith, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc4 next-20180920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-20 Thread kbuild test robot
Hi Keith, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc4 next-20180920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-19 Thread Keith Busch
On Wed, Sep 19, 2018 at 03:02:49PM -0600, Keith Busch wrote: > if (is_hugepd(__hugepd(pmd_val(pmdval { > - page = follow_huge_pd(vma, address, > - __hugepd(pmd_val(pmdval)), flags, > - PMD_SHIFT); > +

Re: [PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-19 Thread Keith Busch
On Wed, Sep 19, 2018 at 03:02:49PM -0600, Keith Busch wrote: > if (is_hugepd(__hugepd(pmd_val(pmdval { > - page = follow_huge_pd(vma, address, > - __hugepd(pmd_val(pmdval)), flags, > - PMD_SHIFT); > +

[PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-19 Thread Keith Busch
This will make it easier to add new parameters that we may wish to thread through these function calls. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- include/linux/huge_mm.h | 12 +-- include/linux/hugetlb.h | 2 +- include/linux/mm.h | 21 -

[PATCH 6/7] mm/gup: Combine parameters into struct

2018-09-19 Thread Keith Busch
This will make it easier to add new parameters that we may wish to thread through these function calls. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- include/linux/huge_mm.h | 12 +-- include/linux/hugetlb.h | 2 +- include/linux/mm.h | 21 -