Hi Arnaldo,
On Mon, Apr 20, 2015 at 06:28:45PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Apr 21, 2015 at 12:22:06AM +0900, Namhyung Kim escreveu:
> > Hi Arnaldo,
> >
> > On Mon, Apr 20, 2015 at 11:00:20AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Sun, Apr 19, 2015 at 01:04:14PM
Hi Arnaldo,
On Mon, Apr 20, 2015 at 06:28:45PM -0300, Arnaldo Carvalho de Melo wrote:
Em Tue, Apr 21, 2015 at 12:22:06AM +0900, Namhyung Kim escreveu:
Hi Arnaldo,
On Mon, Apr 20, 2015 at 11:00:20AM -0300, Arnaldo Carvalho de Melo wrote:
Em Sun, Apr 19, 2015 at 01:04:14PM +0900,
Em Tue, Apr 21, 2015 at 12:22:06AM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
>
> On Mon, Apr 20, 2015 at 11:00:20AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim escreveu:
> > > Currently perf_evsel__hists_browse() function spins on a huge
Hi Arnaldo,
On Mon, Apr 20, 2015 at 11:00:20AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim escreveu:
> > Currently perf_evsel__hists_browse() function spins on a huge loop and
> > handles many key actions. Since it's hard to read and modify,
Em Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim escreveu:
> Currently perf_evsel__hists_browse() function spins on a huge loop and
> handles many key actions. Since it's hard to read and modify, let's
> split it out into small helper functions.
>
> The add_XXX_opt() functions are to
Currently perf_evsel__hists_browse() function spins on a huge loop and
handles many key actions. Since it's hard to read and modify, let's
split it out into small helper functions.
The add_XXX_opt() functions are to register popup menu item on the
selected entry. When it adds an item, it also
On Mon, Apr 20, 2015 at 11:46:07AM +0200, Jiri Olsa wrote:
> On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > continue;
> > case 's':
> > - if (is_report_browser(hbt))
> > - goto
On Mon, Apr 20, 2015 at 11:21:59AM +0200, Jiri Olsa wrote:
> On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > +
> > +static int
> > +add_script_opt(struct popup_option *opt, char **optstr,
> > + struct hist_browser *browser __maybe_unused,
> > +
On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
SNIP
> continue;
> case 's':
> - if (is_report_browser(hbt))
> - goto do_data_switch;
> + if (is_report_browser(hbt)) {
> +
On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
SNIP
> +
> +static int
> +add_script_opt(struct popup_option *opt, char **optstr,
> +struct hist_browser *browser __maybe_unused,
> +struct thread *thread, struct symbol *sym)
> +{
> + if (thread) {
> +
Em Tue, Apr 21, 2015 at 12:22:06AM +0900, Namhyung Kim escreveu:
Hi Arnaldo,
On Mon, Apr 20, 2015 at 11:00:20AM -0300, Arnaldo Carvalho de Melo wrote:
Em Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim escreveu:
Currently perf_evsel__hists_browse() function spins on a huge loop and
Currently perf_evsel__hists_browse() function spins on a huge loop and
handles many key actions. Since it's hard to read and modify, let's
split it out into small helper functions.
The add_XXX_opt() functions are to register popup menu item on the
selected entry. When it adds an item, it also
On Mon, Apr 20, 2015 at 11:46:07AM +0200, Jiri Olsa wrote:
On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
SNIP
continue;
case 's':
- if (is_report_browser(hbt))
- goto do_data_switch;
+
On Mon, Apr 20, 2015 at 11:21:59AM +0200, Jiri Olsa wrote:
On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
SNIP
+
+static int
+add_script_opt(struct popup_option *opt, char **optstr,
+ struct hist_browser *browser __maybe_unused,
+ struct thread
On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
SNIP
continue;
case 's':
- if (is_report_browser(hbt))
- goto do_data_switch;
+ if (is_report_browser(hbt)) {
+
On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
SNIP
+
+static int
+add_script_opt(struct popup_option *opt, char **optstr,
+struct hist_browser *browser __maybe_unused,
+struct thread *thread, struct symbol *sym)
+{
+ if (thread) {
+
Em Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim escreveu:
Currently perf_evsel__hists_browse() function spins on a huge loop and
handles many key actions. Since it's hard to read and modify, let's
split it out into small helper functions.
The add_XXX_opt() functions are to register
Hi Arnaldo,
On Mon, Apr 20, 2015 at 11:00:20AM -0300, Arnaldo Carvalho de Melo wrote:
Em Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim escreveu:
Currently perf_evsel__hists_browse() function spins on a huge loop and
handles many key actions. Since it's hard to read and modify, let's
Currently perf_evsel__hists_browse() function spins on a huge loop and
handles many key actions. Since it's hard to read and modify, let's
split it out into small helper functions.
The add_XXX_opt() functions are to register popup menu item on the
selected entry. When it adds an item, it also
Currently perf_evsel__hists_browse() function spins on a huge loop and
handles many key actions. Since it's hard to read and modify, let's
split it out into small helper functions.
The add_XXX_opt() functions are to register popup menu item on the
selected entry. When it adds an item, it also
20 matches
Mail list logo
