Re: [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt

Hello, On Mon, Aug 27, 2012 at 9:36 PM, Lai Jiangshan wrote: >> But then the completion could be triggered prematurely, no? > > No, the idle_worker_rebind() can't be called until rebind_workers() > finish counting and release the gcwq->lock. I see but I still wanna keep it counting from 1. That

Re: [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt

On Tue, Aug 28, 2012 at 4:05 AM, Tejun Heo wrote: > On Tue, Aug 28, 2012 at 01:58:26AM +0800, Lai Jiangshan wrote: >> Access idle_rebind.cnt is always protected by gcwq->lock, >> don't need to init it as 1. > > But then the completion could be triggered prematurely, no? No, the idle_worker_rebind

Re: [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt

On Tue, Aug 28, 2012 at 01:58:26AM +0800, Lai Jiangshan wrote: > Access idle_rebind.cnt is always protected by gcwq->lock, > don't need to init it as 1. But then the completion could be triggered prematurely, no? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linu

[PATCH 6/7] workqueue: init 0 for idle_rebind.cnt

Access idle_rebind.cnt is always protected by gcwq->lock, don't need to init it as 1. Signed-off-by: Lai Jiangshan --- kernel/workqueue.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ed23c9a..9f38a65 100644 --- a/kernel