Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Andrew Cooper
On 08/02/2021 10:36, Jan Beulich wrote: > On 08.02.2021 11:23, Andrew Cooper wrote: >> On 08/02/2021 09:50, Jan Beulich wrote: >>> On 08.02.2021 10:44, Andrew Cooper wrote: On 06/02/2021 10:49, Juergen Gross wrote: > The ring buffer for user events is used in the local system only, so

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Jan Beulich
On 08.02.2021 11:23, Andrew Cooper wrote: > On 08/02/2021 09:50, Jan Beulich wrote: >> On 08.02.2021 10:44, Andrew Cooper wrote: >>> On 06/02/2021 10:49, Juergen Gross wrote: The ring buffer for user events is used in the local system only, so smp barriers are fine for ensuring

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Andrew Cooper
On 08/02/2021 10:25, Jürgen Groß wrote: > On 08.02.21 11:23, Andrew Cooper wrote: >> On 08/02/2021 09:50, Jan Beulich wrote: >>> On 08.02.2021 10:44, Andrew Cooper wrote: On 06/02/2021 10:49, Juergen Gross wrote: > The ring buffer for user events is used in the local system only, so >

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Jürgen Groß
On 08.02.21 11:23, Andrew Cooper wrote: On 08/02/2021 09:50, Jan Beulich wrote: On 08.02.2021 10:44, Andrew Cooper wrote: On 06/02/2021 10:49, Juergen Gross wrote: The ring buffer for user events is used in the local system only, so smp barriers are fine for ensuring consistency.

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Andrew Cooper
On 08/02/2021 09:50, Jan Beulich wrote: > On 08.02.2021 10:44, Andrew Cooper wrote: >> On 06/02/2021 10:49, Juergen Gross wrote: >>> The ring buffer for user events is used in the local system only, so >>> smp barriers are fine for ensuring consistency. >>> >>> Reported-by: Andrew Cooper >>>

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Jan Beulich
On 08.02.2021 10:44, Andrew Cooper wrote: > On 06/02/2021 10:49, Juergen Gross wrote: >> The ring buffer for user events is used in the local system only, so >> smp barriers are fine for ensuring consistency. >> >> Reported-by: Andrew Cooper >> Signed-off-by: Juergen Gross > > These need to be

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Andrew Cooper
On 06/02/2021 10:49, Juergen Gross wrote: > The ring buffer for user events is used in the local system only, so > smp barriers are fine for ensuring consistency. > > Reported-by: Andrew Cooper > Signed-off-by: Juergen Gross These need to be virt_* to not break in UP builds (on non-x86).

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Jürgen Groß
On 08.02.21 10:38, Jan Beulich wrote: On 06.02.2021 11:49, Juergen Gross wrote: The ring buffer for user events is used in the local system only, so smp barriers are fine for ensuring consistency. Reported-by: Andrew Cooper Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Albeit I

Re: [PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-08 Thread Jan Beulich
On 06.02.2021 11:49, Juergen Gross wrote: > The ring buffer for user events is used in the local system only, so > smp barriers are fine for ensuring consistency. > > Reported-by: Andrew Cooper > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Albeit I think "local system" is at least

[PATCH 6/7] xen/evtch: use smp barriers for user event ring

2021-02-06 Thread Juergen Gross
The ring buffer for user events is used in the local system only, so smp barriers are fine for ensuring consistency. Reported-by: Andrew Cooper Signed-off-by: Juergen Gross --- drivers/xen/evtchn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/evtchn.c