Re: [PATCH 6/8] cgroup: remove cgroup->name

2014-02-12 Thread Li Zefan
On 2014/2/12 16:27, Tejun Heo wrote: > On Wed, Feb 12, 2014 at 03:52:20PM +0800, Li Zefan wrote: >> The caller won't check the return value but pass it to printk/seq_printf, >> but now cgroup_path() might return -ENAMETOOLONG.. > > cgroup_path() returns NULL on overflow which printk handles fine,

Re: [PATCH 6/8] cgroup: remove cgroup->name

2014-02-12 Thread Tejun Heo
On Wed, Feb 12, 2014 at 03:52:20PM +0800, Li Zefan wrote: > The caller won't check the return value but pass it to printk/seq_printf, > but now cgroup_path() might return -ENAMETOOLONG.. cgroup_path() returns NULL on overflow which printk handles fine, no? Thanks. -- tejun -- To unsubscribe fro

Re: [PATCH 6/8] cgroup: remove cgroup->name

2014-02-11 Thread Li Zefan
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > index dd52e7f..30eee3b 100644 > --- a/kernel/sched/debug.c > +++ b/kernel/sched/debug.c > @@ -111,8 +111,7 @@ static char *task_group_path(struct task_group *tg) > if (autogroup_path(tg, group_path, PATH_MAX)) > return

[PATCH 6/8] cgroup: remove cgroup->name

2014-02-08 Thread Tejun Heo
cgroup->name handling became quite complicated over time involving dedicated struct cgroup_name for RCU protection. Now that cgroup is on kernfs, we can drop all of it and simply use kernfs_name/path() and friends. Replace cgroup->name and all related code with kernfs name/path constructs. * Rei

Re: [PATCH 6/8] cgroup: remove cgroup->name

2014-01-29 Thread Tejun Heo
On Wed, Jan 29, 2014 at 01:09:07PM +0100, Michal Hocko wrote: > Btw. after this change we should drop part of the comment above > oom_info_lock: Updated the comment to /* oom_info_lock ensures that parallel ooms do not interleave */ Thanks! -- tejun -- To unsubscribe from this list: send the

Re: [PATCH 6/8] cgroup: remove cgroup->name

2014-01-29 Thread Michal Hocko
On Tue 28-01-14 18:59:43, Tejun Heo wrote: > cgroup->name handling became quite complicated over time involving > dedicated struct cgroup_name for RCU protection. Now that cgroup is > on kernfs, we can drop all of it and simply use kernfs_name/path() and > friends. Replace cgroup->name and all re

Re: [PATCH 6/8] cgroup: remove cgroup->name

2014-01-29 Thread Peter Zijlstra
On Tue, Jan 28, 2014 at 06:59:43PM -0500, Tejun Heo wrote: > cgroup->name handling became quite complicated over time involving > dedicated struct cgroup_name for RCU protection. Now that cgroup is > on kernfs, we can drop all of it and simply use kernfs_name/path() and > friends. Replace cgroup-

[PATCH 6/8] cgroup: remove cgroup->name

2014-01-28 Thread Tejun Heo
cgroup->name handling became quite complicated over time involving dedicated struct cgroup_name for RCU protection. Now that cgroup is on kernfs, we can drop all of it and simply use kernfs_name/path() and friends. Replace cgroup->name and all related code with kernfs name/path constructs. * Rei