Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-11 Thread Wanpeng Li
2018-01-10 0:08 GMT+08:00 Paolo Bonzini : > Oops, I missed these. > > On 09/01/2018 15:22, Konrad Rzeszutek Wilk wrote: >>> +if (have_spec_ctrl) { >>> +rdmsrl(MSR_IA32_SPEC_CTRL, svm->spec_ctrl); >>> +if (svm->spec_ctrl != 0) >> Perhaps just : >> >> if (svm->spec_c

Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-11 Thread Paolo Bonzini
On 10/01/2018 21:13, Tom Lendacky wrote: > On 1/9/2018 6:03 AM, Paolo Bonzini wrote: >> Direct access to MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD is important >> for performance. Allow load/store of MSR_IA32_SPEC_CTRL, restore guest >> IBRS on VM entry and set it to 0 on VM exit (because Linux doe

Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-10 Thread Tom Lendacky
On 1/9/2018 6:03 AM, Paolo Bonzini wrote: > Direct access to MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD is important > for performance. Allow load/store of MSR_IA32_SPEC_CTRL, restore guest > IBRS on VM entry and set it to 0 on VM exit (because Linux does not use > it yet). > > Signed-off-by: Paolo

Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-09 Thread Liran Alon
- liran.a...@oracle.com wrote: > - pbonz...@redhat.com wrote: > > > Direct access to MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD is > > important > > for performance. Allow load/store of MSR_IA32_SPEC_CTRL, restore > > guest > > IBRS on VM entry and set it to 0 on VM exit (because Linux do

Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-09 Thread Liran Alon
- pbonz...@redhat.com wrote: > Direct access to MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD is > important > for performance. Allow load/store of MSR_IA32_SPEC_CTRL, restore > guest > IBRS on VM entry and set it to 0 on VM exit (because Linux does not > use > it yet). > > Signed-off-by: Paolo

Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-09 Thread Paolo Bonzini
Oops, I missed these. On 09/01/2018 15:22, Konrad Rzeszutek Wilk wrote: >> +if (have_spec_ctrl) { >> +rdmsrl(MSR_IA32_SPEC_CTRL, svm->spec_ctrl); >> +if (svm->spec_ctrl != 0) > Perhaps just : > > if (svm->spec_ctrl) ? > > And above too? These will become != SPE

Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-09 Thread Paolo Bonzini
On 09/01/2018 15:22, Konrad Rzeszutek Wilk wrote: >> +have_spec_ctrl = cpu_has_spec_ctrl(); >> +if (have_spec_ctrl) >> +pr_info("kvm: SPEC_CTRL available\n"); >> +else >> +pr_info("kvm: SPEC_CTRL not available\n"); > Perhaps just > > pr_info("kvm: SPEC_CTR

Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-09 Thread Konrad Rzeszutek Wilk
On Tue, Jan 09, 2018 at 01:03:08PM +0100, Paolo Bonzini wrote: > Direct access to MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD is important > for performance. Allow load/store of MSR_IA32_SPEC_CTRL, restore guest > IBRS on VM entry and set it to 0 on VM exit (because Linux does not use > it yet). > >

[PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest

2018-01-09 Thread Paolo Bonzini
Direct access to MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD is important for performance. Allow load/store of MSR_IA32_SPEC_CTRL, restore guest IBRS on VM entry and set it to 0 on VM exit (because Linux does not use it yet). Signed-off-by: Paolo Bonzini --- arch/x86/kvm/svm.c | 42 +++