Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-02 Thread Frederic Weisbecker
On Thu, Aug 01, 2013 at 04:40:05PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 04:21:11PM +0200, Frederic Weisbecker wrote: > > > > Yeah, just go with a single global state for now.. > > > > > > The perf default is to create inherited counter, which are per cpu > > > anyway. So we'll no

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2013 at 04:21:11PM +0200, Frederic Weisbecker wrote: > > > Yeah, just go with a single global state for now.. > > > > The perf default is to create inherited counter, which are per cpu > > anyway. So we'll not loose much. > > So you mean that I keep the per cpu state when event->c

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Frederic Weisbecker
On Thu, Aug 01, 2013 at 04:06:15PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 04:03:52PM +0200, Peter Zijlstra wrote: > > On Thu, Aug 01, 2013 at 03:55:27PM +0200, Frederic Weisbecker wrote: > > > On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > > > > > > > > Where the

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Frederic Weisbecker
On Thu, Aug 01, 2013 at 04:03:52PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 03:55:27PM +0200, Frederic Weisbecker wrote: > > On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > > > > > > Where the freq thing is new and shiney, but we already had the other > > > two. Of

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2013 at 04:03:52PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 03:55:27PM +0200, Frederic Weisbecker wrote: > > On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > > > > > > Where the freq thing is new and shiney, but we already had the other > > > two. Of

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2013 at 03:55:27PM +0200, Frederic Weisbecker wrote: > On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > > > > Where the freq thing is new and shiney, but we already had the other > > two. Of those, cgroup events must be per cpu so that should be good, > > the branc

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2013 at 03:39:21PM +0200, Jiri Olsa wrote: > On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > > two. Of those, cgroup events must be per cpu so that should be good, > cgroup is cpu only: jah! :-) -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Frederic Weisbecker
On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 02:46:58PM +0200, Jiri Olsa wrote: > > On Tue, Jul 23, 2013 at 02:31:04AM +0200, Frederic Weisbecker wrote: > > > This is going to be used by the full dynticks subsystem > > > as a finer-grained information to

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Jiri Olsa
On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 02:46:58PM +0200, Jiri Olsa wrote: > > On Tue, Jul 23, 2013 at 02:31:04AM +0200, Frederic Weisbecker wrote: > > > This is going to be used by the full dynticks subsystem > > > as a finer-grained information to

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > the branch_stack thing tests ATTACH_TASK, which should also be good, but > leaves me wonder wth they do for those that are attached to tasks. Ah found it, in intel_pmu_lbr_enable() we test cpuc->lbr_context against event->ctx and wi

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2013 at 02:46:58PM +0200, Jiri Olsa wrote: > On Tue, Jul 23, 2013 at 02:31:04AM +0200, Frederic Weisbecker wrote: > > This is going to be used by the full dynticks subsystem > > as a finer-grained information to know when to keep and > > when to stop the tick. > > > > Original-patc

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Jiri Olsa
On Thu, Aug 01, 2013 at 02:46:58PM +0200, Jiri Olsa wrote: > On Tue, Jul 23, 2013 at 02:31:04AM +0200, Frederic Weisbecker wrote: > > This is going to be used by the full dynticks subsystem > > as a finer-grained information to know when to keep and > > when to stop the tick. > > > > Original-patc

Re: [PATCH 6/8] perf: Account freq events per cpu

2013-08-01 Thread Jiri Olsa
On Tue, Jul 23, 2013 at 02:31:04AM +0200, Frederic Weisbecker wrote: > This is going to be used by the full dynticks subsystem > as a finer-grained information to know when to keep and > when to stop the tick. > > Original-patch-by: Peter Zijlstra > Signed-off-by: Frederic Weisbecker > Cc: Jiri

[PATCH 6/8] perf: Account freq events per cpu

2013-07-22 Thread Frederic Weisbecker
This is going to be used by the full dynticks subsystem as a finer-grained information to know when to keep and when to stop the tick. Original-patch-by: Peter Zijlstra Signed-off-by: Frederic Weisbecker Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Namhyung Kim Cc: Ingo Molnar Cc: Arnaldo Carvalho d