subject:"\[PATCH 6\/8\] staging\: pi433\: use defines for shifting register values"

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

2017-12-13 Thread Valentin Vidic

On Wed, Dec 13, 2017 at 05:32:28PM +0200, Marcus Wolf wrote: > Am 13.12.2017 um 16:21 schrieb Valentin Vidic: > > Avoid shifting by magic numbers and use defines instead: > > > >SHIFT_DATAMODUL_MODULATION_TYPE > >SHIFT_LNA_CURRENT_GAIN > > > > Signed-off-by: Valentin Vidic > > --- > >

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

2017-12-13 Thread Marcus Wolf

Am 13.12.2017 um 16:21 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead: SHIFT_DATAMODUL_MODULATION_TYPE SHIFT_LNA_CURRENT_GAIN Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_registers.h |

[PATCH 6/8] staging: pi433: use defines for shifting register values

2017-12-13 Thread Valentin Vidic

Avoid shifting by magic numbers and use defines instead: SHIFT_DATAMODUL_MODULATION_TYPE SHIFT_LNA_CURRENT_GAIN Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_registers.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)