Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-18 Thread Lee Jones
On Thu, 18 Dec 2014, Guenter Roeck wrote: > On Thu, Dec 18, 2014 at 08:26:52AM +, Lee Jones wrote: > > On Wed, 17 Dec 2014, Guenter Roeck wrote: > > > On Wed, Dec 17, 2014 at 04:45:25PM +, Lee Jones wrote: > > > > Signed-off-by: David Paris > > > > Signed-off-by: Lee Jones > > > > > > H

Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-18 Thread Guenter Roeck
On Thu, Dec 18, 2014 at 08:26:52AM +, Lee Jones wrote: > On Wed, 17 Dec 2014, Guenter Roeck wrote: > > On Wed, Dec 17, 2014 at 04:45:25PM +, Lee Jones wrote: > > > Signed-off-by: David Paris > > > Signed-off-by: Lee Jones > > > > Hi Lee and David, > > > > I still have a couple of commen

Re: [STLinux Kernel] [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-18 Thread Lee Jones
On Thu, 18 Dec 2014, Peter Griffin wrote: > Hi Lee, > > On Wed, 17 Dec 2014, Lee Jones wrote: > > > Signed-off-by: David Paris > > Signed-off-by: Lee Jones > > --- > > drivers/watchdog/Kconfig | 13 ++ > > drivers/watchdog/Makefile | 1 + > > drivers/watchdog/st_wdt.c | 323 > > +

Re: [STLinux Kernel] [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-18 Thread Peter Griffin
Hi Lee, On Wed, 17 Dec 2014, Lee Jones wrote: > Signed-off-by: David Paris > Signed-off-by: Lee Jones > --- > drivers/watchdog/Kconfig | 13 ++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/st_wdt.c | 323 > ++ You don't have a patch whi

Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-18 Thread Lee Jones
On Wed, 17 Dec 2014, Guenter Roeck wrote: > On Wed, Dec 17, 2014 at 04:45:25PM +, Lee Jones wrote: > > Signed-off-by: David Paris > > Signed-off-by: Lee Jones > > Hi Lee and David, > > I still have a couple of comments below. Sorry I didn't catch those earlier. > > Thanks, > Guenter > > >

Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-17 Thread Guenter Roeck
On Wed, Dec 17, 2014 at 04:45:25PM +, Lee Jones wrote: > Signed-off-by: David Paris > Signed-off-by: Lee Jones Hi Lee and David, I still have a couple of comments below. Sorry I didn't catch those earlier. Thanks, Guenter > --- > drivers/watchdog/Kconfig | 13 ++ > drivers/watchdog/Mak

[PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-17 Thread Lee Jones
Signed-off-by: David Paris Signed-off-by: Lee Jones --- drivers/watchdog/Kconfig | 13 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/st_wdt.c | 323 ++ 3 files changed, 337 insertions(+) create mode 100644 drivers/watchdog/st_wdt.c diff --

Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-15 Thread Guenter Roeck
On Mon, Dec 15, 2014 at 11:25:36AM +, Lee Jones wrote: > Signed-off-by: David Paris > Signed-off-by: Lee Jones > --- > drivers/watchdog/Kconfig | 13 ++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/st_wdt.c | 312 > ++ > 3 files chang

Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-15 Thread Guenter Roeck
On 12/15/2014 03:25 AM, Lee Jones wrote: Signed-off-by: David Paris Signed-off-by: Lee Jones --- drivers/watchdog/Kconfig | 13 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/st_wdt.c | 312 ++ 3 files changed, 326 insertions(+) creat

Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-15 Thread David Paris
Hi Lee, Something I didn't pointed out before, this driver is only supposed to support LPC_0 for stih407. The enable mask is only coded for LPC_0. Is it a wanted behavior ? In our current implementation here in ST is that LPC_0 is for A9 Watchdog and LPC_1 for A9 global timer. This h

Re: [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-15 Thread David Paris
Hi Lee, 1. During resume stage the st_wdog_setup should be called again to reconfigure LPC RTC as watchdog. 2. For Suspend/resume API, is CONFIG_PM necessary, CONFIG_PM_SLEEP is enough as no PM_RUNTIME in this driver ! This will results in a compilation warning if CONFIG_PM_SLEEP is un

[PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

2014-12-15 Thread Lee Jones
Signed-off-by: David Paris Signed-off-by: Lee Jones --- drivers/watchdog/Kconfig | 13 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/st_wdt.c | 312 ++ 3 files changed, 326 insertions(+) create mode 100644 drivers/watchdog/st_wdt.c diff --